third_party/WebKit/Source/web/WebLocalFrameImpl.h - Issue 1423053002: Make document.activeElement work with OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1423053002: Make document.activeElement work with OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-preserve-page-focus-on-subframe-navigations

Patch Set: Change plumbing a bit: use focusDocumentView on WebView and remove clearFocus from WebLocalFrame Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/FocusController.h ('K') | « third_party/WebKit/Source/core/page/FocusController.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | third_party/WebKit/public/web/WebView.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

index afb6358aacabf5e153dd80bef5167ee14393f977..9d966fd4f3f56a58565c21012add4cbc877b5940 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

@@ -179,7 +179,6 @@ public:

bool setCompositionFromExistingText(int compositionStart, int compositionEnd, const WebVector<WebCompositionUnderline>& underlines) override;

void extendSelectionAndDelete(int before, int after) override;

void setCaretVisible(bool) override;

- void clearFocus() override;

int printBegin(const WebPrintParams&, const WebNode& constrainToNode) override;

float printPage(int pageToPrint, WebCanvas*) override;

float getPrintPageShrink(int page) override;