third_party/WebKit/Source/core/page/FocusController.h - Issue 1423053002: Make document.activeElement work with OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FocusController.h

Issue 1423053002: Make document.activeElement work with OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-preserve-page-focus-on-subframe-navigations

Patch Set: Change plumbing a bit: use focusDocumentView on WebView and remove clearFocus from WebLocalFrame Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScope.cpp ('k') | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | third_party/WebKit/public/web/WebView.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/FocusController.h

diff --git a/third_party/WebKit/Source/core/page/FocusController.h b/third_party/WebKit/Source/core/page/FocusController.h

index 1fcfbff0c48b81c0ba1730dd8e6cbd7997780df2..85a7a67814aa7d6794f174d62573f39c3624ba83 100644

--- a/third_party/WebKit/Source/core/page/FocusController.h

+++ b/third_party/WebKit/Source/core/page/FocusController.h

@@ -52,6 +52,7 @@ public:

void setFocusedFrame(PassRefPtrWillBeRawPtr<Frame>);

void focusDocumentView(PassRefPtrWillBeRawPtr<Frame>);

LocalFrame* focusedFrame() const;

+ Frame* focusedFrameEvenIfRemote() const { return m_focusedFrame.get(); }

dcheng 2015/11/04 01:46:21 Crazy idea: can we move the logic for determining

alexmos 2015/11/04 18:08:12 I like this - done! Please take a look.

Frame* focusedOrMainFrame() const;

bool setInitialFocus(WebFocusType);