content/renderer/render_frame_impl.h - Issue 1423053002: Make document.activeElement work with OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1423053002: Make document.activeElement work with OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-preserve-page-focus-on-subframe-navigations

Patch Set: Remove some plumbing that should instead be introduced in the window.focus() CL. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 7d8ee4905b39fe5dc2cd4cc78879ea1880ef8a12..d5b029d386e7b299d73f4a7847a221a1b413e893 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -735,7 +735,6 @@ class CONTENT_EXPORT RenderFrameImpl

void OnDidUpdateSandboxFlags(blink::WebSandboxFlags flags);

void OnSetFrameOwnerProperties(

const blink::WebFrameOwnerProperties& frame_owner_properties);

- void OnClearFocus();

void OnTextTrackSettingsChanged(

const FrameMsg_TextTrackSettings_Params& params);

void OnPostMessageEvent(const FrameMsg_PostMessage_Params& params);

« content/common/frame_messages.h ('K') | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »