content/common/frame_messages.h - Issue 1423053002: Make document.activeElement work with OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1423053002: Make document.activeElement work with OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-preserve-page-focus-on-subframe-navigations

Patch Set: Remove some plumbing that should instead be introduced in the window.focus() CL. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index f9f231da9efddc289ca56be33aa2239004009d61..4b5c8139bf41f59ddc02a8c95a4f32c80b1bf906 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -654,8 +654,9 @@ IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateName, std::string /* name */)

// new origin.

IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateOrigin, url::Origin /* origin */)

-// Notifies this frame that it lost focus to a frame in another process.

-IPC_MESSAGE_ROUTED0(FrameMsg_ClearFocus)

+// Notifies this frame or proxy that it is now focused. This is used to

+// support cross-process focused frame changes.

+IPC_MESSAGE_ROUTED0(FrameMsg_SetFocusedFrame);

alexmos 2015/11/04 21:53:59 Currently, this is only called on proxies, but in

Charlie Reis 2015/11/04 22:23:42 Acknowledged.

// Send to the RenderFrame to set text tracks state and style settings.

// Sent for top-level frames.

« content/browser/frame_host/frame_tree.cc ('K') | « content/browser/site_per_process_browsertest.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »