Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: components/crash/content/app/BUILD.gn

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial patch for review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/BUILD.gn
diff --git a/components/crash/content/app/BUILD.gn b/components/crash/content/app/BUILD.gn
index e0985c559c35bda415494669abc6678445c5fb91..0359fdcfb680d9f599015bf50f9bfdd1d0b95754 100644
--- a/components/crash/content/app/BUILD.gn
+++ b/components/crash/content/app/BUILD.gn
@@ -15,12 +15,12 @@ source_set("lib") {
]
include_dirs = [ "../../../../breakpad/src" ]
+
+ deps = [
+ "//base",
+ ]
}
-# Note: if you depend on this target, you need to either link in
-# content.gyp:content_common, or add content/public/common/content_switches.cc
-# to your sources.
-#
# GYP version: components/crash.gypi:crash_component
source_set("app") {
sources = [
@@ -49,9 +49,10 @@ source_set("app") {
defines = [ "CRASH_IMPLEMENTATION" ]
deps = [
+ ":lib",
"//base",
"//base:base_static",
- ":lib",
+ "//content/public/common",
]
if (is_android) {

Powered by Google App Engine
This is Rietveld 408576698