Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: components/crash/content/app/BUILD.gn

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial patch for review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 source_set("lib") { 9 source_set("lib") {
10 sources = [ 10 sources = [
11 "crash_keys_win.cc", 11 "crash_keys_win.cc",
12 "crash_keys_win.h", 12 "crash_keys_win.h",
13 "crash_reporter_client.cc", 13 "crash_reporter_client.cc",
14 "crash_reporter_client.h", 14 "crash_reporter_client.h",
15 ] 15 ]
16 16
17 include_dirs = [ "../../../../breakpad/src" ] 17 include_dirs = [ "../../../../breakpad/src" ]
18
19 deps = [
20 "//base",
21 ]
18 } 22 }
19 23
20 # Note: if you depend on this target, you need to either link in
21 # content.gyp:content_common, or add content/public/common/content_switches.cc
22 # to your sources.
23 #
24 # GYP version: components/crash.gypi:crash_component 24 # GYP version: components/crash.gypi:crash_component
25 source_set("app") { 25 source_set("app") {
26 sources = [ 26 sources = [
27 "breakpad_linux_impl.h", 27 "breakpad_linux_impl.h",
28 "breakpad_mac.h", 28 "breakpad_mac.h",
29 "breakpad_mac.mm", 29 "breakpad_mac.mm",
30 "breakpad_win.cc", 30 "breakpad_win.cc",
31 "breakpad_win.h", 31 "breakpad_win.h",
32 "hard_error_handler_win.cc", 32 "hard_error_handler_win.cc",
33 "hard_error_handler_win.h", 33 "hard_error_handler_win.h",
34 ] 34 ]
35 35
36 if (is_android) { 36 if (is_android) {
37 libs = [ "log" ] 37 libs = [ "log" ]
38 } 38 }
39 39
40 if (is_android || is_linux) { 40 if (is_android || is_linux) {
41 # Want these files on both Linux and Android. 41 # Want these files on both Linux and Android.
42 set_sources_assignment_filter([]) 42 set_sources_assignment_filter([])
43 sources += [ 43 sources += [
44 "breakpad_linux.cc", 44 "breakpad_linux.cc",
45 "breakpad_linux.h", 45 "breakpad_linux.h",
46 ] 46 ]
47 } 47 }
48 48
49 defines = [ "CRASH_IMPLEMENTATION" ] 49 defines = [ "CRASH_IMPLEMENTATION" ]
50 50
51 deps = [ 51 deps = [
52 ":lib",
52 "//base", 53 "//base",
53 "//base:base_static", 54 "//base:base_static",
54 ":lib", 55 "//content/public/common",
55 ] 56 ]
56 57
57 if (is_android) { 58 if (is_android) {
58 defines += [ "CHROME_BUILD_ID=" + android_chrome_build_id ] 59 defines += [ "CHROME_BUILD_ID=" + android_chrome_build_id ]
59 } 60 }
60 61
61 if (is_mac) { 62 if (is_mac) {
62 deps += [ "//breakpad" ] 63 deps += [ "//breakpad" ]
63 } else if (is_win) { 64 } else if (is_win) {
64 deps += [ 65 deps += [
65 "//sandbox", 66 "//sandbox",
66 "//breakpad:breakpad_handler", 67 "//breakpad:breakpad_handler",
67 68
68 #'../breakpad/breakpad.gyp:breakpad_sender', TODO(GYP) 69 #'../breakpad/breakpad.gyp:breakpad_sender', TODO(GYP)
69 ] 70 ]
70 } else if (is_posix && !is_ios) { 71 } else if (is_posix && !is_ios) {
71 deps += [ "//breakpad:client" ] 72 deps += [ "//breakpad:client" ]
72 } 73 }
73 } 74 }
74 75
75 source_set("test_support") { 76 source_set("test_support") {
76 deps = [ 77 deps = [
77 ":lib", 78 ":lib",
78 ] 79 ]
79 } 80 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698