Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Unified Diff: components/crash.gypi

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial patch for review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash.gypi
diff --git a/components/crash.gypi b/components/crash.gypi
index 8ad506d283479c108d41555f9c4283c086eaf4b2..f9ba6ad913786e27bdca8549eb9e206d9e7f42bc 100644
--- a/components/crash.gypi
+++ b/components/crash.gypi
@@ -169,10 +169,6 @@
],
},
{
- # Note: if you depend on this target, you need to either link in
- # content.gyp:content_common, or add
- # content/public/common/content_switches.cc to your sources.
- #
Dirk Pranke 2015/10/26 21:57:27 In theory, depending directly on content should no
# GN version: //components/crash/content/app
# TODO(mark): https://crbug.com/466890: merge this target with
@@ -201,6 +197,7 @@
'dependencies': [
'crash_component_non_mac',
'crash_component_lib',
+ '../content/content.gyp:content_common',
Robert Sesek 2015/10/27 21:11:16 Is this the right target on which to add the depen
Dirk Pranke 2015/10/27 21:30:47 I think you're probably right.
'../base/base.gyp:base',
],
'defines': ['CRASH_IMPLEMENTATION'],
@@ -288,9 +285,6 @@
['OS=="win" and target_arch=="ia32"', {
'targets': [
{
- # Note: if you depend on this target, you need to either link in
- # content.gyp:content_common, or add
- # content/public/common/content_switches.cc to your sources.
'target_name': 'breakpad_win64',
'type': 'static_library',
'sources': [
@@ -317,6 +311,7 @@
'../base/base.gyp:base_win64',
'../breakpad/breakpad.gyp:breakpad_handler_win64',
'../breakpad/breakpad.gyp:breakpad_sender_win64',
+ '../content/content.gyp:content_common',
'../sandbox/sandbox.gyp:sandbox_win64',
],
'configurations': {
« no previous file with comments | « .gn ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698