Fix missing dependencies for //components/crash.

components/crash.gypi

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //components/crash/core/browser
       'target_name': 'crash_core_browser',
       'type': 'static_library',
@@ skipping 151 matching lines @@
             # Need 'target_conditions' to override default filename_rules to include
             # the files on Android.
             ['OS=="android"', {
               'sources/': [
                 ['include', '^crash/content/app/breakpad_linux\\.cc$'],
               ],
             }],
           ],
         },
         {
-          # Note: if you depend on this target, you need to either link in
-          # content.gyp:content_common, or add
-          # content/public/common/content_switches.cc to your sources.
-          #

[Dirk Pranke, 2015/10/26 21:57:27]

In theory, depending directly on content should now be safe.

           # GN version: //components/crash/content/app
 
           # TODO(mark): https://crbug.com/466890: merge this target with
           # crash_component_non_mac.
           #
           # Most of this target is actually in its dependency,
           # crash_component_non_mac.  See the comment in that target for an
           # explanation for the split. The split is temporary and the two targets
           # will be unified again soon.
           'target_name': 'crash_component',
           'variables': {
             'conditions': [
               ['OS != "mac" ', {
                 # There are no source files on any platform but Mac OS X.
                 'crash_component_target_type%': 'none',
               }, {
                 'crash_component_target_type%': 'static_library',
               }],
             ],
           },
           'type': '<(crash_component_target_type)',
           'sources': [
             'crash/content/app/crashpad_mac.h',
             'crash/content/app/crashpad_mac.mm',
           ],
           'dependencies': [
             'crash_component_non_mac',
             'crash_component_lib',
+            '../content/content.gyp:content_common',

[Robert Sesek, 2015/10/27 21:11:16]

Is this the right target on which to add the dependency? It seems like this
should go on crash_component_non_mac.

[Dirk Pranke, 2015/10/27 21:30:47]

I think you're probably right.

             '../base/base.gyp:base',
           ],
           'defines': ['CRASH_IMPLEMENTATION'],
           'conditions': [
             ['OS=="mac"', {
               'dependencies': [
                 '../third_party/crashpad/crashpad/client/client.gyp:crashpad_client',
               ],
             }],
           ],
@@ skipping 67 matching lines @@
               'sources': [
                 'crash/content/tools/crash_service.cc',
                 'crash/content/tools/crash_service.h',
               ],
             },
           ],
         }],
         ['OS=="win" and target_arch=="ia32"', {
           'targets': [
             {
-              # Note: if you depend on this target, you need to either link in
-              # content.gyp:content_common, or add
-              # content/public/common/content_switches.cc to your sources.
               'target_name': 'breakpad_win64',
               'type': 'static_library',
               'sources': [
                 'crash/content/app/breakpad_linux.cc',
                 'crash/content/app/breakpad_linux.h',
                 'crash/content/app/breakpad_linux_impl.h',
                 'crash/content/app/breakpad_mac.h',
                 'crash/content/app/breakpad_mac.mm',
                 'crash/content/app/breakpad_win.cc',
                 'crash/content/app/breakpad_win.h',
                 # TODO(siggi): test the x64 version too.
                 'crash/content/app/crash_keys_win.cc',
                 'crash/content/app/crash_keys_win.h',
                 'crash/content/app/crash_reporter_client.cc',
                 'crash/content/app/crash_reporter_client.h',
                 'crash/content/app/hard_error_handler_win.cc',
                 'crash/content/app/hard_error_handler_win.h',
               ],
               'defines': [
                 'COMPILE_CONTENT_STATICALLY',
                 'CRASH_IMPLEMENTATION',
               ],
               'dependencies': [
                 '../base/base.gyp:base_win64',
                 '../breakpad/breakpad.gyp:breakpad_handler_win64',
                 '../breakpad/breakpad.gyp:breakpad_sender_win64',
+                '../content/content.gyp:content_common',
                 '../sandbox/sandbox.gyp:sandbox_win64',
               ],
               'configurations': {
                 'Common_Base': {
                   'msvs_target_platform': 'x64',
                 },
               },
             },
             {
               'target_name': 'breakpad_crash_service_win64',
@@ skipping 63 matching lines @@
                   ],
                 }],
               ],
             },
           ],
         }],
       ],
     }],
   ],
 }