Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1422983002: Fix format produced by chart data recorder. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix format produced by chart data recorder. - dashboard wants a dictionary of dictionaries indexed by name of the measurement - the uploading logic already serializes the chart data together w/ metadata, recorder should return Python data structure R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dd48bf5ed9763b8b01a495046f73610c6b8e3d88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M mojo/devtools/common/devtoolslib/perf_dashboard.py View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py View 6 chunks +7 lines, -12 lines 0 comments Download
M mojo/devtools/common/mojo_benchmark View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ppi
Hi Etienne, ptal.
5 years, 1 month ago (2015-10-26 14:02:31 UTC) #3
etiennej
lgtm
5 years, 1 month ago (2015-10-26 16:36:23 UTC) #4
ppi
5 years, 1 month ago (2015-10-27 10:42:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd48bf5ed9763b8b01a495046f73610c6b8e3d88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698