Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py

Issue 1422983002: Fix format produced by chart data recorder. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/devtoolslib/perf_dashboard.py ('k') | mojo/devtools/common/mojo_benchmark » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py
diff --git a/mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py b/mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py
index b9c3b17e909b635cc8c0f908f2dd0bc30bbb8619..98714c96fdf630d57e4c3af328c928435e825b1f 100644
--- a/mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py
+++ b/mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py
@@ -5,7 +5,6 @@
"""Tests for the Chromium Performance Dashboard data format implementation."""
import imp
-import json
import os.path
import sys
import unittest
@@ -24,7 +23,7 @@ class ChartDataRecorderTest(unittest.TestCase):
def test_empty(self):
"""Tests chart data with no charts."""
recorder = ChartDataRecorder('benchmark')
- result = json.loads(recorder.get_json())
+ result = recorder.get_chart_data()
self.assertEquals({
'format_version': '1.0',
'benchmark_name': 'benchmark',
@@ -36,7 +35,7 @@ class ChartDataRecorderTest(unittest.TestCase):
recorder.record_scalar('chart', 'val1', 'ms', 1)
recorder.record_scalar('chart', 'val2', 'ms', 2)
- result = json.loads(recorder.get_json())
+ result = recorder.get_chart_data()
self.assertEquals('1.0', result['format_version'])
self.assertEquals('benchmark', result['benchmark_name'])
@@ -45,14 +44,12 @@ class ChartDataRecorderTest(unittest.TestCase):
self.assertEquals(2, len(charts['chart']))
self.assertEquals({
'type': 'scalar',
- 'name': 'val1',
'units': 'ms',
- 'value': 1}, charts['chart'][0])
+ 'value': 1}, charts['chart']['val1'])
self.assertEquals({
'type': 'scalar',
- 'name': 'val2',
'units': 'ms',
- 'value': 2}, charts['chart'][1])
+ 'value': 2}, charts['chart']['val2'])
def test_two_charts(self):
"""Tests chart data with two samples over two charts."""
@@ -60,7 +57,7 @@ class ChartDataRecorderTest(unittest.TestCase):
recorder.record_scalar('chart1', 'val1', 'ms', 1)
recorder.record_scalar('chart2', 'val2', 'ms', 2)
- result = json.loads(recorder.get_json())
+ result = recorder.get_chart_data()
self.assertEquals('1.0', result['format_version'])
self.assertEquals('benchmark', result['benchmark_name'])
@@ -69,12 +66,10 @@ class ChartDataRecorderTest(unittest.TestCase):
self.assertEquals(1, len(charts['chart1']))
self.assertEquals({
'type': 'scalar',
- 'name': 'val1',
'units': 'ms',
- 'value': 1}, charts['chart1'][0])
+ 'value': 1}, charts['chart1']['val1'])
self.assertEquals(1, len(charts['chart2']))
self.assertEquals({
'type': 'scalar',
- 'name': 'val2',
'units': 'ms',
- 'value': 2}, charts['chart2'][0])
+ 'value': 2}, charts['chart2']['val2'])
« no previous file with comments | « mojo/devtools/common/devtoolslib/perf_dashboard.py ('k') | mojo/devtools/common/mojo_benchmark » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698