Fixing remaining VC++ 2015 64-bit build breaks

third_party/WebKit/Source/platform/TraceEvent.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 251 matching lines @@
     template<bool dummyMangle> class MangleBehavior {
     public:
         template<typename T> explicit MangleBehavior(T id) : m_data(reinterpret_cast<unsigned long long>(id)) { }
         unsigned long long data() const { return m_data; }
     private:
         unsigned long long m_data;
     };
     typedef MangleBehavior<false> DontMangle;
     typedef MangleBehavior<true> ForceMangle;
 
-    TraceID(const void* id, unsigned* flags) :
-        m_data(static_cast<unsigned long long>(reinterpret_cast<unsigned long>(id)))
+    TraceID(const void* id, unsigned* flags)
+        : m_data(static_cast<unsigned long long>(reinterpret_cast<uintptr_t>(id)))

[Nico, 2015/11/16 21:31:07]

either cast to unsigned long long or change m_data to uintptr_t (which would
make it 32-bit on 32-bit systems)

[brucedawson, 2015/11/17 00:24:39]

The reason for leaving it as-is is that TraceID can be initialized with an
unsigned long long (so m_id can't be uintptr_t) and the double cast matches the
canonical version in base\trace_event.h (which this had diverged from).

I'd initially cast to uintptr_t and let the conversion to unsigned long long be
implicit, but wfh@ complained:
https://codereview.chromium.org/1422773008/diff/120001/third_party/WebKit/Sou...

At least all of the variants should be correct.

     {
         *flags |= TRACE_EVENT_FLAG_MANGLE_ID;
     }
     TraceID(ForceMangle id, unsigned* flags) : m_data(id.data())
     {
         *flags |= TRACE_EVENT_FLAG_MANGLE_ID;
     }
     TraceID(DontMangle id, unsigned*) : m_data(id.data()) { }
     TraceID(unsigned long long id, unsigned*) : m_data(id) { }
     TraceID(unsigned long id, unsigned*) : m_data(id) { }
@@ skipping 327 matching lines @@
     const char* m_categoryGroup;
     const char* m_name;
     IDType m_id;
 };
 
 } // namespace TraceEvent
 
 } // namespace blink
 
 #endif