Fixing remaining VC++ 2015 64-bit build breaks

third_party/WebKit/Source/platform/TraceEvent.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 251 matching lines @@
     template<bool dummyMangle> class MangleBehavior {
     public:
         template<typename T> explicit MangleBehavior(T id) : m_data(reinterpret_cast<unsigned long long>(id)) { }
         unsigned long long data() const { return m_data; }
     private:
         unsigned long long m_data;
     };
     typedef MangleBehavior<false> DontMangle;
     typedef MangleBehavior<true> ForceMangle;
 
-    TraceID(const void* id, unsigned* flags) :
-        m_data(static_cast<unsigned long long>(reinterpret_cast<unsigned long>(id)))
+    TraceID(const void* id, unsigned* flags)
+        : m_data(reinterpret_cast<uintptr_t>(id))

[Will Harris, 2015/11/10 18:05:14]

this looks like a behavior change, before the id was truncated to 32-bit even on
64-bit, now it's not.

[brucedawson, 2015/11/10 18:43:26]

Yep, it's a behavior change because the previous code was buggy. They copied
from base\trace_event.h which now does this correctly.

[Will Harris, 2015/11/10 19:45:46]

trace_event.h does

data_(static_cast<unsigned long long>(reinterpret_cast<uintptr_t>(id)))

can't you just match this by changing unsigned long to uintptr_t? It seems
strange to be inconsistent here.

[brucedawson, 2015/11/10 19:54:33]

I guess, although the whole idea of casting from uintptr_t to ulonglong is very
odd - why are we casting to an equal or larger type?

     {
         *flags |= TRACE_EVENT_FLAG_MANGLE_ID;
     }
     TraceID(ForceMangle id, unsigned* flags) : m_data(id.data())
     {
         *flags |= TRACE_EVENT_FLAG_MANGLE_ID;
     }
     TraceID(DontMangle id, unsigned*) : m_data(id.data()) { }
     TraceID(unsigned long long id, unsigned*) : m_data(id) { }
     TraceID(unsigned long id, unsigned*) : m_data(id) { }
@@ skipping 327 matching lines @@
     const char* m_categoryGroup;
     const char* m_name;
     IDType m_id;
 };
 
 } // namespace TraceEvent
 
 } // namespace blink
 
 #endif