[sync] Abstract most ProfileSyncService //chrome deps

components/sync_driver/sync_client.h

Index: components/sync_driver/sync_client.h
diff --git a/components/sync_driver/sync_client.h b/components/sync_driver/sync_client.h
index d32b2ff21cb58d58b8726561a5910ef17dd35ab4..e9164d73c0ac50f538ad95f9837e89b3819b7ed0 100644
--- a/components/sync_driver/sync_client.h
+++ b/components/sync_driver/sync_client.h
@@ -23,6 +23,12 @@ class AutocompleteSyncableService;
 class PersonalDataManager;
 }  // namespace autofill
 
+namespace base {
+class FilePath;
+class SequencedWorkerPool;
+class SingleThreadTaskRunner;
+}  // namespace base
+
 namespace bookmarks {
 class BookmarkModel;
 }  // namespace bookmarks
@@ -35,6 +41,14 @@ namespace history {
 class HistoryService;
 }  // namespace history
 
+namespace invalidation {
+class InvalidationService;
+}  // namespace invalidation
+
+namespace net {
+class URLRequestContextGetter;
+}  // namespace net
+
 namespace password_manager {
 class PasswordStore;
 }  // namespace password_manager
@@ -47,6 +61,10 @@ namespace sync_sessions {
 class SyncSessionsClient;
 }  // namespace sync_sessions
 
+namespace version_info {
+enum class Channel;
+}
+
 namespace sync_driver {
 
 class SyncApiComponentFactory;
@@ -94,6 +112,7 @@ class SyncClient {
   virtual scoped_refptr<autofill::AutofillWebDataService>
   GetWebDataService() = 0;
   virtual BookmarkUndoService* GetBookmarkUndoServiceIfExists() = 0;
+  virtual invalidation::InvalidationService* GetInvalidationService() = 0;
   virtual scoped_refptr<syncer::ExtensionsActivity> GetExtensionsActivity() = 0;
   virtual sync_sessions::SyncSessionsClient* GetSyncSessionsClient() = 0;
 
@@ -113,6 +132,24 @@ class SyncClient {
   // Returns the current SyncApiComponentFactory instance.
   virtual SyncApiComponentFactory* GetSyncApiComponentFactory() = 0;
 
+  // Returns the path of the base directory under which sync should store its
+  // data.
+  virtual base::FilePath GetBaseDirectory() = 0;

[Nicolas Zea, 2015/10/31 00:15:34]

How many of these can be plumbed into the ProfileSyncService via the
constructor? If possible, I'd prefer to have as much via the constructor as we
can, particularly if it's a static value that doesn't change at runtime.

[blundell, 2015/11/02 16:08:35]

Done.

+
+  // Returns the URLRequestContext in which sync should operate.
+  virtual net::URLRequestContextGetter* GetURLRequestContext() = 0;
+
+  // Returns an identifier representing this client for debugging purposes.
+  virtual std::string GetDebugIdentifier() = 0;
+
+  // Returns the channel of the embedder.
+  virtual version_info::Channel GetChannel() = 0;
+
+  // Accessors for threads.
+  virtual scoped_refptr<base::SingleThreadTaskRunner> GetDBThread() = 0;
+  virtual scoped_refptr<base::SingleThreadTaskRunner> GetFileThread() = 0;
+  virtual base::SequencedWorkerPool* GetBlockingPool() = 0;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(SyncClient);
 };