Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1422753007: Cache all chrome.loadTimes info before passing them to setters. (Closed)

Created:
3 years, 9 months ago by meacer
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache all chrome.loadTimes info before passing them to setters. The setters can invalidate the pointers frame, data_source and document_state. BUG=549251 Committed: https://crrev.com/4026d85fcded8c4ee5113cb1bd1a7e8149e03827 Cr-Commit-Position: refs/heads/master@{#357201}

Patch Set 1 #

Patch Set 2 : c_str #

Total comments: 1

Patch Set 3 : thestig comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -64 lines) Patch
M chrome/renderer/loadtimes_extension_bindings.cc View 1 2 1 chunk +66 lines, -64 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
meacer
3 years, 9 months ago (2015-10-30 20:04:04 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1422753007/diff/20001/chrome/renderer/loadtimes_extension_bindings.cc File chrome/renderer/loadtimes_extension_bindings.cc (right): https://codereview.chromium.org/1422753007/diff/20001/chrome/renderer/loadtimes_extension_bindings.cc#newcode102 chrome/renderer/loadtimes_extension_bindings.cc:102: if (frame) { Would you mind rewriting the ...
3 years, 9 months ago (2015-10-30 20:30:57 UTC) #3
meacer
On 2015/10/30 20:30:57, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/1422753007/diff/20001/chrome/renderer/loadtimes_extension_bindings.cc > File chrome/renderer/loadtimes_extension_bindings.cc (right): ...
3 years, 9 months ago (2015-10-30 20:46:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422753007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422753007/40001
3 years, 9 months ago (2015-10-30 20:47:28 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 9 months ago (2015-10-30 22:12:56 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2015-10-30 22:14:39 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4026d85fcded8c4ee5113cb1bd1a7e8149e03827
Cr-Commit-Position: refs/heads/master@{#357201}

Powered by Google App Engine
This is Rietveld 408576698