Cache all chrome.loadTimes info before passing them to setters.

Cache all chrome.loadTimes info before passing them to setters.

The setters can invalidate the pointers frame, data_source and document_state.

BUG=549251
Committed: https://crrev.com/4026d85fcded8c4ee5113cb1bd1a7e8149e03827
Cr-Commit-Position: refs/heads/master@{#357201}

[meacer, 2015-10-30 20:04:03]

meacer@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-10-30 20:30:57]

lgtm

https://codereview.chromium.org/1422753007/diff/20001/chrome/renderer/loadtim...
File chrome/renderer/loadtimes_extension_bindings.cc (right):

https://codereview.chromium.org/1422753007/diff/20001/chrome/renderer/loadtim...
chrome/renderer/loadtimes_extension_bindings.cc:102: if (frame) {
Would you mind rewriting the code using early returns so the main body of this
function isn't so squished?

if (!frame) {
  args.GetReturnValue().SetNull();
  return;
}

...
if (!data_source) ...

[meacer, 2015-10-30 20:46:59]

On 2015/10/30 20:30:57, Lei Zhang wrote:
> lgtm
> 
>
https://codereview.chromium.org/1422753007/diff/20001/chrome/renderer/loadtim...
> File chrome/renderer/loadtimes_extension_bindings.cc (right):
> 
>
https://codereview.chromium.org/1422753007/diff/20001/chrome/renderer/loadtim...
> chrome/renderer/loadtimes_extension_bindings.cc:102: if (frame) {
> Would you mind rewriting the code using early returns so the main body of this
> function isn't so squished?
> 
> if (!frame) {
>   args.GetReturnValue().SetNull();
>   return;
> }
> 
> ...
> if (!data_source) ...

Done.

[meacer, 2015-10-30 20:47:08]

The CQ bit was checked by meacer@chromium.org

[meacer, 2015-10-30 20:47:09]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1422753007/#ps40001
(title: "thestig comments")

[commit-bot: I haz the power, 2015-10-30 20:47:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422753007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422753007/40001

[commit-bot: I haz the power, 2015-10-30 22:12:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-30 22:14:39]

Patchset 3 (id:??) landed as
https://crrev.com/4026d85fcded8c4ee5113cb1bd1a7e8149e03827
Cr-Commit-Position: refs/heads/master@{#357201}