Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1422713012: Devtools Animations: Listen to all animation play state changes (Closed)

Created:
5 years, 1 month ago by samli
Modified:
5 years, 1 month ago
Reviewers:
dstockwell, pfeldman
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, Inactive, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools Animations: Listen to all animation play state changes This change adds animation instrumentation for all play state changes. The animation agent then decides how to use this information to ensure that the front-end is always notified of start times where applicable and where start times will not be received. This ensures our pending animations are always flushed in a timely fashion. BUG=447083, 554266 Committed: https://crrev.com/5251c29d5e7dd2dc399419d6e1a638b1e4765954 Cr-Commit-Position: refs/heads/master@{#359383}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -114 lines) Patch
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-cancel.html View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-cancel-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-start.html View 1 2 3 2 chunks +1 line, -15 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-start-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-paused-css-animation.html View 1 2 3 2 chunks +17 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-paused-css-animation-expected.txt View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-zero-duration.html View 1 2 3 4 3 chunks +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-zero-duration-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 2 3 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 2 3 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
samli
5 years, 1 month ago (2015-11-10 19:04:56 UTC) #2
samli
PTAL.
5 years, 1 month ago (2015-11-11 19:00:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422713012/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422713012/80001
5 years, 1 month ago (2015-11-11 19:33:41 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/87028)
5 years, 1 month ago (2015-11-11 19:44:11 UTC) #10
dstockwell
lgtm
5 years, 1 month ago (2015-11-11 21:37:02 UTC) #11
dstockwell
lgtm
5 years, 1 month ago (2015-11-11 21:37:02 UTC) #12
pfeldman
lgtm
5 years, 1 month ago (2015-11-12 18:48:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422713012/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422713012/80001
5 years, 1 month ago (2015-11-12 18:52:49 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-12 21:01:21 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 21:02:11 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5251c29d5e7dd2dc399419d6e1a638b1e4765954
Cr-Commit-Position: refs/heads/master@{#359383}

Powered by Google App Engine
This is Rietveld 408576698