third_party/WebKit/Source/core/animation/Animation.cpp - Issue 1422713012: Devtools Animations: Listen to all animation play state changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 1422713012: Devtools Animations: Listen to all animation play state changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-zero-duration-expected.txt ('k') | third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/Animation.cpp

diff --git a/third_party/WebKit/Source/core/animation/Animation.cpp b/third_party/WebKit/Source/core/animation/Animation.cpp

index 758e2bc5ef68a04a992a474f1ad0a0b7cba1dc1c..5bfd50c07e0b5a022946330ec7f712dbaa71bc11 100644

--- a/third_party/WebKit/Source/core/animation/Animation.cpp

+++ b/third_party/WebKit/Source/core/animation/Animation.cpp

@@ -894,8 +894,6 @@ void Animation::cancel()

m_playState = Idle;

m_startTime = nullValue();

m_currentTimePending = false;

- InspectorInstrumentation::didCancelAnimation(m_timeline->document(), m_sequenceNumber);

}

void Animation::beginUpdatingState()

@@ -1057,8 +1055,8 @@ Animation::PlayStateUpdateScope::~PlayStateUpdateScope()

}

m_animation->endUpdatingState();

- if (oldPlayState != newPlayState && newPlayState == Running)

- InspectorInstrumentation::didStartAnimation(m_animation->timeline()->document(), m_animation);

+ if (oldPlayState != newPlayState)

+ InspectorInstrumentation::animationPlayStateChanged(m_animation->timeline()->document(), m_animation, oldPlayState, newPlayState);

}

bool Animation::addEventListenerInternal(const AtomicString& eventType, PassRefPtrWillBeRawPtr<EventListener> listener, const EventListenerOptions& options)