Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422623002: Build fixes for fnl/musl (Closed)

Created:
5 years, 2 months ago by cdotstout
Modified:
5 years, 2 months ago
Reviewers:
jamesr, viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix android build #

Total comments: 2

Patch Set 3 : use existing queue.h in compat #

Patch Set 4 : update README.chromium in //third_party #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
M base/debug/stack_trace.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 8 chunks +9 lines, -7 lines 0 comments Download
M base/files/file_util_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/config/allocator.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/fnl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M services/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M services/native_support/make_pty_pair.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M shell/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/libevent/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libevent/README.chromium View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libteken/README.chromium View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libteken/teken/teken.c View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
cdotstout
5 years, 2 months ago (2015-10-21 20:15:39 UTC) #2
jamesr
Did you write the //third_party changes or find them somewhere? If the latter, you should ...
5 years, 2 months ago (2015-10-21 22:55:43 UTC) #3
jamesr
All the stuff outside of //third_party LGTM as is
5 years, 2 months ago (2015-10-21 22:56:20 UTC) #4
cdotstout
On 2015/10/21 22:55:43, jamesr wrote: > Did you write the //third_party changes or find them ...
5 years, 2 months ago (2015-10-22 00:03:16 UTC) #5
cdotstout
https://codereview.chromium.org/1422623002/diff/20001/third_party/libevent/linux/sys/queue.h File third_party/libevent/linux/sys/queue.h (right): https://codereview.chromium.org/1422623002/diff/20001/third_party/libevent/linux/sys/queue.h#newcode36 third_party/libevent/linux/sys/queue.h:36: * This file defines five types of data structures: ...
5 years, 2 months ago (2015-10-22 00:03:24 UTC) #6
jamesr
OK thanks, that lgtm
5 years, 2 months ago (2015-10-22 00:05:22 UTC) #7
cdotstout
5 years, 2 months ago (2015-10-22 15:17:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
34776a703d8cce41052e5a3867a23d8970fbb549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698