Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: services/BUILD.gn

Issue 1422623002: Build fixes for fnl/musl (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: update README.chromium in //third_party Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/BUILD.gn ('k') | services/native_support/make_pty_pair.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/BUILD.gn
diff --git a/services/BUILD.gn b/services/BUILD.gn
index 4e9798548ac04a3020a1199bb854d25976da8869..22a7c57776cc3490c30e3fb17130d2d6f1dd4abc 100644
--- a/services/BUILD.gn
+++ b/services/BUILD.gn
@@ -60,7 +60,8 @@ group("services") {
# TODO(jamesr): We only support building V8 snapshot data on a linux host
# since it needs a 32 bit toolchain and we don't have one configured for mac
# hosts.
- if (host_os == "linux") {
+ # TODO(cstout): javascript/v8 build support for fnl/musl
+ if (!is_fnl && host_os == "linux") {
deps += [ "//services/js" ]
}
}
@@ -96,7 +97,8 @@ group("tests") {
# TODO(jamesr): We only support building V8 snapshot data on a linux host since it
# needs a 32 bit toolchain and we don't have one configured for mac hosts.
- if (host_os == "linux") {
+ # TODO(cstout): javascript/v8 build support for fnl/musl
+ if (!is_fnl && host_os == "linux") {
deps += [ "//services/js:tests" ]
}
« no previous file with comments | « mojo/BUILD.gn ('k') | services/native_support/make_pty_pair.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698