Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController for aura Android

Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController for aura Android

For aura Android, AutofillPopupViewViews will be used. And
in its implementation, AutofillPopupController::GetValueFontListForRow
and AutofillPopupController::GetLabelFontList were used.
The two functions were disabled for Android. And the reason
was gfx::GetStringWidth is not implemented for Android. But
they are implemented for aura. So this CL enables them for
aura Android

BUG=507792
Committed: https://crrev.com/4c18758f292ffe08cec1da9642ca896484851b7f
Cr-Commit-Position: refs/heads/master@{#360127}

[bshe, 2015-11-03 20:26:05]

Description was changed from

==========
Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController
for aura Android

The above two functions were disabled on Android because gfx::GetStringWidth
is not implemented for Android. But they are for aura. So enable them for aura
Android

BUG=
==========

to

==========
Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController
for aura Android

For aura Android, AutofillPopupViewViews will be used. And
in its implementation, AutofillPopupController::GetValueFontListForRow
and AutofillPopupController::GetLabelFontList were used.
The two functions were disabled for Android. And the reason
was gfx::GetStringWidth is not implemented for Android. But
they are implemented for aura. So this CL enables them for
aura Android

BUG=507792
==========

[bshe, 2015-11-03 21:48:00]

Patchset #2 (id:20001) has been deleted

[bshe, 2015-11-16 18:55:22]

bshe@chromium.org changed reviewers:
+ estade@chromium.org, mfomitchev@chromium.org

[bshe, 2015-11-16 18:55:22]

Hi Mikhail and Evan.

Do you mind to take a look at this CL? See CL description for details about it.

Thanks!

Biao

[Evan Stade, 2015-11-16 19:39:15]

lgtm

[mfomitchev, 2015-11-16 22:45:33]

LGTM with a nit

https://codereview.chromium.org/1422533008/diff/40001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_controller_impl.cc (right):

https://codereview.chromium.org/1422533008/diff/40001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_controller_impl.cc:660: #endif
nit: When the ifdef spawns a few dozen lines like here, the comment at #endif
could be valuable, so I'd update the comment in this case rather than remove it.

[bshe, 2015-11-17 17:03:23]

https://codereview.chromium.org/1422533008/diff/40001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_controller_impl.cc (right):

https://codereview.chromium.org/1422533008/diff/40001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_controller_impl.cc:660: #endif
On 2015/11/16 22:45:32, mfomitchev wrote:
> nit: When the ifdef spawns a few dozen lines like here, the comment at #endif
> could be valuable, so I'd update the comment in this case rather than remove
it.

The problem of comment is that it could be easily out of date, which may make
the situation even worse. That's why I decide to remove it instead of update it.
But if you have strong opinion on this. I can update the comment.

[mfomitchev, 2015-11-17 17:12:34]

On 2015/11/17 17:03:23, bshe wrote:
>
https://codereview.chromium.org/1422533008/diff/40001/chrome/browser/ui/autof...
> File chrome/browser/ui/autofill/autofill_popup_controller_impl.cc (right):
> 
>
https://codereview.chromium.org/1422533008/diff/40001/chrome/browser/ui/autof...
> chrome/browser/ui/autofill/autofill_popup_controller_impl.cc:660: #endif
> On 2015/11/16 22:45:32, mfomitchev wrote:
> > nit: When the ifdef spawns a few dozen lines like here, the comment at
#endif
> > could be valuable, so I'd update the comment in this case rather than remove
> it.
> 
> The problem of comment is that it could be easily out of date, which may make
> the situation even worse. That's why I decide to remove it instead of update
it.
> But if you have strong opinion on this. I can update the comment.

It's not particularly strong, feel free to land as is.

[bshe, 2015-11-17 18:24:15]

On 2015/11/17 17:12:34, mfomitchev wrote:
> On 2015/11/17 17:03:23, bshe wrote:
> >
>
https://codereview.chromium.org/1422533008/diff/40001/chrome/browser/ui/autof...
> > File chrome/browser/ui/autofill/autofill_popup_controller_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/1422533008/diff/40001/chrome/browser/ui/autof...
> > chrome/browser/ui/autofill/autofill_popup_controller_impl.cc:660: #endif
> > On 2015/11/16 22:45:32, mfomitchev wrote:
> > > nit: When the ifdef spawns a few dozen lines like here, the comment at
> #endif
> > > could be valuable, so I'd update the comment in this case rather than
remove
> > it.
> > 
> > The problem of comment is that it could be easily out of date, which may
make
> > the situation even worse. That's why I decide to remove it instead of update
> it.
> > But if you have strong opinion on this. I can update the comment.
> 
> It's not particularly strong, feel free to land as is.

cool. thanks! I will land it as it is.

[bshe, 2015-11-17 18:24:18]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2015-11-17 18:25:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422533008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422533008/40001

[commit-bot: I haz the power, 2015-11-17 19:12:43]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-11-17 19:13:42]

Patchset 2 (id:??) landed as
https://crrev.com/4c18758f292ffe08cec1da9642ca896484851b7f
Cr-Commit-Position: refs/heads/master@{#360127}

[bshe, 2016-01-06 14:59:30]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1563853002/ by bshe@chromium.org.

The reason for reverting is: We dont need to support Aura Android at current
stage. Revert related code..