Issue 142253002: Added checking for higher bit being set in GetAsyncKeyState return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 142253002: Added checking for higher bit being set in GetAsyncKeyState return value. (Closed)

Created:
6 years, 11 months ago by Shrikant Kelkar

Modified:
6 years, 11 months ago

Reviewers:
cpu_(ooo_6.6-7.5), nduca

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added checking for higher bit being set in GetAsyncKeyState return value. This is an experimental fix, as it is difficult to repro actual bug. BUG=254545 R=cpu TBR=nduca Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246028

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/browser/renderer_host/input/web_input_event_builders_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/142253002/1

6 years, 11 months ago (2014-01-19 16:28:48 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=192508

6 years, 11 months ago (2014-01-19 17:56:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/142253002/1

6 years, 11 months ago (2014-01-21 12:58:21 UTC) #5

Message was sent while issue was closed.

Change committed as 246028

Expand Messages | Collapse Messages