Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: third_party/WebKit/Source/core/input/TouchActionUtil.cpp

Issue 1422513006: Simplify TouchAction enum to be a simple bit flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix windows build warning Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/TouchActionUtil.cpp
diff --git a/third_party/WebKit/Source/core/input/TouchActionUtil.cpp b/third_party/WebKit/Source/core/input/TouchActionUtil.cpp
index 69eabf3cc1822b6ba951436b0ed2f073e0b1ebfe..8ef15dfd82e63625386253489b08f6a660e7a236 100644
--- a/third_party/WebKit/Source/core/input/TouchActionUtil.cpp
+++ b/third_party/WebKit/Source/core/input/TouchActionUtil.cpp
@@ -28,19 +28,6 @@ static bool supportsTouchAction(const LayoutObject& object)
return true;
}
-static TouchAction intersectTouchAction(TouchAction action1, TouchAction action2)
-{
- if (action1 == TouchActionNone || action2 == TouchActionNone)
- return TouchActionNone;
- if (action1 == TouchActionAuto)
- return action2;
- if (action2 == TouchActionAuto)
- return action1;
- if (!(action1 & action2))
- return TouchActionNone;
- return action1 & action2;
-}
-
} // namespace
TouchAction computeEffectiveTouchAction(const Node& node)
@@ -53,7 +40,7 @@ TouchAction computeEffectiveTouchAction(const Node& node)
if (LayoutObject* layoutObject = curNode->layoutObject()) {
if (supportsTouchAction(*layoutObject)) {
TouchAction action = layoutObject->style()->touchAction();
- effectiveTouchAction = intersectTouchAction(action, effectiveTouchAction);
+ effectiveTouchAction &= action;
if (effectiveTouchAction == TouchActionNone)
break;
}

Powered by Google App Engine
This is Rietveld 408576698