SkTime::GetNSecs()

SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot

Committed: https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c

Committed: https://skia.googlesource.com/skia/+/38a88e4c0c28a7be981aac7bb4a198ad95a62a63

Committed: https://skia.googlesource.com/skia/+/33eefcd58bffc35355382dd7b1b79a02b99f8c6c

[mtklein_C, 2015-10-22 17:54:41]

Description was changed from

==========
SkTime::GetNSecs()

   - Ports the meat of high-precision wall timers from tools/ to SkTime.
   - SkTime::GetMSec() is now a wrapper for GetNSec().

BUG=skia:
==========

to

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - SkTime::GetMSec() is now a wrapper for GetNSec().
   - Delete unused tools/timer code.

BUG=skia:
==========

[mtklein_C, 2015-10-22 17:54:57]

Description was changed from

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - SkTime::GetMSec() is now a wrapper for GetNSec().
   - Delete unused tools/timer code.

BUG=skia:
==========

to

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSec() in terms of SkTime::GetNSec().
   - Delete unused tools/timer code.

BUG=skia:
==========

[mtklein_C, 2015-10-22 17:55:09]

Description was changed from

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSec() in terms of SkTime::GetNSec().
   - Delete unused tools/timer code.

BUG=skia:
==========

to

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

BUG=skia:
==========

[mtklein_C, 2015-10-22 18:05:51]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 18:06:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/80001

[mtklein_C, 2015-10-22 18:06:21]

mtklein@chromium.org changed reviewers:
+ caryclark@google.com

[commit-bot: I haz the power, 2015-10-22 18:08:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 18:08:04]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[mtklein_C, 2015-10-22 18:10:32]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 18:10:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/120001

[commit-bot: I haz the power, 2015-10-22 18:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 18:15:02]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein_C, 2015-10-22 18:18:56]

Description was changed from

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

BUG=skia:
==========

to

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:
==========

[mtklein_C, 2015-10-22 18:19:07]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 18:19:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/140001

[commit-bot: I haz the power, 2015-10-22 18:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 18:30:07]

Dry run: This issue passed the CQ dry run.

[caryclark, 2015-10-22 18:43:49]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-10-22 18:43:49]

lgtm

Wow! What a great cleanup. Thank you for doing this. LGTM

[commit-bot: I haz the power, 2015-10-22 18:44:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/140001

[commit-bot: I haz the power, 2015-10-22 18:45:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 18:45:19]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2015-10-22 18:46:18]

mtklein@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[mtklein, 2015-10-22 18:46:18]

+Reed for include/

Do we consider SkTime public API?

[mtklein_C, 2015-10-22 19:32:21]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 19:32:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/160001

[reed1, 2015-10-22 19:37:55]

lgtm

[commit-bot: I haz the power, 2015-10-22 19:43:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 19:43:23]

Dry run: This issue passed the CQ dry run.

[mtklein, 2015-10-22 19:44:42]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-10-22 19:44:42]

The patchset sent to the CQ was uploaded after l-g-t-m from caryclark@google.com
Link to the patchset: https://codereview.chromium.org/1422513003/#ps160001
(title: "always query frequency once")

[commit-bot: I haz the power, 2015-10-22 19:44:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/160001

[commit-bot: I haz the power, 2015-10-22 19:47:08]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

[caryclark, 2015-10-22 20:02:43]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/1420923003/ by caryclark@google.com.

The reason for reverting is: broke chromeos.

[mtklein_C, 2015-10-22 20:22:25]

Description was changed from

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217
==========

to

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot
==========

[mtklein_C, 2015-10-22 20:22:58]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2015-10-22 20:22:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
caryclark@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/1422513003/#ps180001
(title: "lrt")

[commit-bot: I haz the power, 2015-10-22 20:23:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/180001

[commit-bot: I haz the power, 2015-10-22 20:33:25]

Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c

[reed1, 2015-10-22 23:22:04]

Is this breaking the DEPS roll?

FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared
-Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
-Wl,--icf=all -pthread -m64 -Wl,--export-dynamic -o ./libskia.so
-Wl,-soname=libskia.so @./libskia.so.rsp && { readelf -d ./libskia.so | grep
SONAME ; nm -gD -f p ./libskia.so | cut -f1-2 -d' '; } > ./libskia.so.tmp && if
! cmp -s ./libskia.so.tmp ./libskia.so.TOC; then mv ./libskia.so.tmp
./libskia.so.TOC; fi
../../third_party/skia/src/core/SkTime.cpp:56: error: undefined reference to
'clock_gettime'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[mtklein, 2015-10-23 00:48:54]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1417753003/ by mtklein@google.com.

The reason for reverting is: https://codereview.chromium.org/1412453006.

[mtklein, 2015-10-23 13:11:32]

Description was changed from

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot

Committed:
https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c
==========

to

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot

Committed:
https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c
==========

[mtklein, 2015-10-23 13:11:38]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 13:11:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/200001

[mtklein, 2015-10-23 13:14:38]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-10-23 13:23:09]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-10-23 13:23:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
caryclark@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/1422513003/#ps200001
(title: "use std::chrono")

[commit-bot: I haz the power, 2015-10-23 13:23:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/200001

[commit-bot: I haz the power, 2015-10-23 13:24:14]

Committed patchset #11 (id:200001) as
https://skia.googlesource.com/skia/+/38a88e4c0c28a7be981aac7bb4a198ad95a62a63

[mtklein, 2015-10-23 13:40:06]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/1422623003/ by mtklein@google.com.

The reason for reverting is: Times don't look like they make sense on Windows..

[mtklein, 2015-10-23 13:44:08]

Description was changed from

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot

Committed:
https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c

Committed:
https://skia.googlesource.com/skia/+/38a88e4c0c28a7be981aac7bb4a198ad95a62a63
==========

to

==========
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot

Committed:
https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c

Committed:
https://skia.googlesource.com/skia/+/38a88e4c0c28a7be981aac7bb4a198ad95a62a63
==========

[mtklein, 2015-10-23 13:45:18]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 13:45:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/220001

[mtklein, 2015-10-23 13:47:16]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-10-23 14:00:45]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-10-23 14:00:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
caryclark@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/1422513003/#ps220001
(title: "#else std::chrono")

[commit-bot: I haz the power, 2015-10-23 14:00:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422513003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422513003/220001

[commit-bot: I haz the power, 2015-10-23 14:02:09]

Committed patchset #12 (id:220001) as
https://skia.googlesource.com/skia/+/33eefcd58bffc35355382dd7b1b79a02b99f8c6c