Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422493003: Change Widget subclasses to use a CullRect instead of an IntRect for painting. (Closed)

Created:
5 years, 1 month ago by chrishtr
Modified:
5 years, 1 month ago
Reviewers:
wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change Widget subclasses to use a CullRect instead of an IntRect for painting. BUG=541817 Committed: https://crrev.com/6598addaf1cfa4ef9bdf38d5baf0582b0f89686b Cr-Commit-Position: refs/heads/master@{#356727}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -141 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.h View 1 2 3 4 5 6 2 chunks +3 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.cpp View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Widget.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/CullRect.h View 1 2 3 4 5 1 chunk +58 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/paint/CullRect.cpp View 1 2 chunks +9 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp View 4 chunks +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
chrishtr
5 years, 1 month ago (2015-10-28 15:58:28 UTC) #3
wkorman
lgtm https://codereview.chromium.org/1422493003/diff/80001/third_party/WebKit/Source/platform/graphics/paint/CullRect.h File third_party/WebKit/Source/platform/graphics/paint/CullRect.h (right): https://codereview.chromium.org/1422493003/diff/80001/third_party/WebKit/Source/platform/graphics/paint/CullRect.h#newcode4 third_party/WebKit/Source/platform/graphics/paint/CullRect.h:4: #ifndef CullRect_h +1 blank above https://codereview.chromium.org/1422493003/diff/80001/third_party/WebKit/Source/platform/graphics/paint/CullRect.h#newcode7 third_party/WebKit/Source/platform/graphics/paint/CullRect.h:7: // ...
5 years, 1 month ago (2015-10-28 22:43:29 UTC) #4
chrishtr
https://codereview.chromium.org/1422493003/diff/80001/third_party/WebKit/Source/platform/graphics/paint/CullRect.h File third_party/WebKit/Source/platform/graphics/paint/CullRect.h (right): https://codereview.chromium.org/1422493003/diff/80001/third_party/WebKit/Source/platform/graphics/paint/CullRect.h#newcode4 third_party/WebKit/Source/platform/graphics/paint/CullRect.h:4: #ifndef CullRect_h On 2015/10/28 at 22:43:29, wkorman wrote: > ...
5 years, 1 month ago (2015-10-28 23:10:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422493003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422493003/100001
5 years, 1 month ago (2015-10-28 23:12:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/150605) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-10-28 23:25:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422493003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422493003/120001
5 years, 1 month ago (2015-10-28 23:46:44 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 1 month ago (2015-10-29 01:37:39 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 01:38:23 UTC) #15
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/6598addaf1cfa4ef9bdf38d5baf0582b0f89686b
Cr-Commit-Position: refs/heads/master@{#356727}

Powered by Google App Engine
This is Rietveld 408576698