Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1422493003: Change Widget subclasses to use a CullRect instead of an IntRect for painting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 IntPoint convertSelfToChild(const Widget* child, const IntPoint& point) cons t override 507 IntPoint convertSelfToChild(const Widget* child, const IntPoint& point) cons t override
508 { 508 {
509 IntPoint newPoint = point; 509 IntPoint newPoint = point;
510 if (!isFrameViewScrollbar(child)) 510 if (!isFrameViewScrollbar(child))
511 newPoint = frameToContents(point); 511 newPoint = frameToContents(point);
512 newPoint.moveBy(-child->location()); 512 newPoint.moveBy(-child->location());
513 return newPoint; 513 return newPoint;
514 } 514 }
515 515
516 // Widget override. Handles painting of the contents of the view as well as the scrollbars. 516 // Widget override. Handles painting of the contents of the view as well as the scrollbars.
517 void paint(GraphicsContext*, const IntRect&) const override; 517 void paint(GraphicsContext*, const CullRect&) const override;
518 void paint(GraphicsContext*, const GlobalPaintFlags, const IntRect&) const; 518 void paint(GraphicsContext*, const GlobalPaintFlags, const CullRect&) const;
519 void paintContents(GraphicsContext*, const GlobalPaintFlags, const IntRect& damageRect) const; 519 void paintContents(GraphicsContext*, const GlobalPaintFlags, const IntRect& damageRect) const;
520 520
521 // Widget overrides to ensure that our children's visibility status is kept up to date when we get shown and hidden. 521 // Widget overrides to ensure that our children's visibility status is kept up to date when we get shown and hidden.
522 void show() override; 522 void show() override;
523 void hide() override; 523 void hide() override;
524 void setParentVisible(bool) override; 524 void setParentVisible(bool) override;
525 525
526 bool isPointInScrollbarCorner(const IntPoint&); 526 bool isPointInScrollbarCorner(const IntPoint&);
527 bool scrollbarCornerPresent() const; 527 bool scrollbarCornerPresent() const;
528 IntRect scrollCornerRect() const override; 528 IntRect scrollCornerRect() const override;
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
905 static const unsigned visualPixelThreshold = 32 * 32; 905 static const unsigned visualPixelThreshold = 32 * 32;
906 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 906 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
907 setIsVisuallyNonEmpty(); 907 setIsVisuallyNonEmpty();
908 } 908 }
909 909
910 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 910 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
911 911
912 } // namespace blink 912 } // namespace blink
913 913
914 #endif // FrameView_h 914 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698