Disable loads and stores to global vars through property cell shortcuts installed into parent scrip…

Disable loads and stores to global vars through property cell shortcuts installed into parent script context.

The plan is to implement the same idea using vector IC machinery.

Committed: https://crrev.com/be5720c2e3a228e56eade6bbdb5279eab6e242d9
Cr-Commit-Position: refs/heads/master@{#31438}

[Igor Sheludko, 2015-10-21 11:40:52]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-10-21 11:44:45]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2015-10-21 12:13:41]

ishell@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Igor Sheludko, 2015-10-21 12:13:41]

PTAL

[Benedikt Meurer, 2015-10-21 12:55:04]

lgtm

[Igor Sheludko, 2015-10-21 12:56:20]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2015-10-21 12:56:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422463004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422463004/40001

[commit-bot: I haz the power, 2015-10-21 13:00:34]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2015-10-21 13:00:46]

Patchset 1 (id:??) landed as
https://crrev.com/be5720c2e3a228e56eade6bbdb5279eab6e242d9
Cr-Commit-Position: refs/heads/master@{#31438}

[rmcilroy, 2015-10-21 16:25:14]

Could you please CC me or one of the interpreter team when you make changes like
this that affect the interpreter / interpreter tests - I had no idea global
loads had changed and the first I knew was when in-flight tests started failing
after I synced.

[rmcilroy, 2015-10-21 16:28:36]

On 2015/10/21 16:25:14, rmcilroy wrote:
> Could you please CC me or one of the interpreter team when you make changes
like
> this that affect the interpreter / interpreter tests - I had no idea global
> loads had changed and the first I knew was when in-flight tests started
failing
> after I synced.

We've now got no tests for LoadGlobal / StoreGlobal / CallGlobal here. Should I
add tests for the !FLAG_global_var_shortcuts mode or is this going to change
again in a day or two?

[Igor Sheludko, 2015-10-21 16:37:57]

On 2015/10/21 16:28:36, rmcilroy wrote:
> On 2015/10/21 16:25:14, rmcilroy wrote:
> > Could you please CC me or one of the interpreter team when you make changes
> like
> > this that affect the interpreter / interpreter tests - I had no idea global
> > loads had changed and the first I knew was when in-flight tests started
> failing
> > after I synced.
> 
> We've now got no tests for LoadGlobal / StoreGlobal / CallGlobal here. Should
I
> add tests for the !FLAG_global_var_shortcuts mode or is this going to change
> again in a day or two?

I'm sorry I didn't inform your team. You don't need to care about these tests. I
already updated them in the follow-up CL:
https://codereview.chromium.org/1419823003/