src/flag-definitions.h - Issue 1422463004: Disable loads and stores to global vars through property cell shortcuts installed into parent scrip…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 1422463004: Disable loads and stores to global vars through property cell shortcuts installed into parent scrip… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index 927ce27d7cd947820cb84075429bcf9ff92c02ec..f523d103f9806bbc33264956c303164cde643129 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -700,7 +700,6 @@ DEFINE_BOOL(use_idle_notification, true,

DEFINE_BOOL(use_ic, true, "use inline caching")

DEFINE_BOOL(trace_ic, false, "trace inline cache state transitions")

DEFINE_BOOL(vector_stores, true, "use vectors for store ics")

-DEFINE_BOOL(global_var_shortcuts, true, "use ic-less global loads and stores")

// macro-assembler-ia32.cc

DEFINE_BOOL(native_code_counters, false,

@@ -1083,6 +1082,8 @@ DEFINE_BOOL(unbox_double_fields, V8_DOUBLE_FIELDS_UNBOXING,

"enable in-object double fields unboxing (64-bit only)")

DEFINE_IMPLICATION(unbox_double_fields, track_double_fields)

+DEFINE_BOOL(global_var_shortcuts, false, "use ic-less global loads and stores")

// Cleanup...

#undef FLAG_FULL

« no previous file with comments | « no previous file | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »