Fix presubmit.py tests.

Fix presubmit.py tests.

Presubmit tests in chromium-build have been broken since https://codereview.chromium.org/23033018.

This fixes that, and adds some info about how to change the test data.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245717

[ghost stip (do not use), 2014-01-18 01:19:38]

fix broken presubmit tests

[cmp, 2014-01-18 01:46:06]

lgtm

https://codereview.chromium.org/142243002/diff/50001/app_test.py
File app_test.py (right):

https://codereview.chromium.org/142243002/diff/50001/app_test.py#newcode219
app_test.py:219: # 'retrain' the test expectations.
Thanks for commenting this.  It was actually the main reason I kept this code
around, so +1.

[commit-bot: I haz the power, 2014-01-18 01:54:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stip@chromium.org/142243002/50001

[commit-bot: I haz the power, 2014-01-18 01:54:25]

Presubmit check for 142243002-50001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
nosetests failed!
Command nosetests --with-gae --gae-lib-root=/b/google_appengine returned
non-zero exit status 1
Traceback (most recent call last):
  File "/usr/local/bin/nosetests", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2707, in
<module>
    working_set.require(__requires__)
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 686, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 584, in resolve
    raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: nose==1.1.2


Pylint (11 files) (15.68s) failed
************* Module app_test
F0401: 79,4:MainTestCase.test_main_page_redirect: Unable to import 'webtest'
F0401: 99,4:AppTestCase.test_app: Unable to import 'webtest'
F0401:110,4:AppTestCase.test_app_blob: Unable to import 'webtest'
F0401:121,4:AppTestCase.test_app_unicode: Unable to import 'webtest'
F0401:133,4:AppTestCase.test_app_unicode_blob: Unable to import 'webtest'
F0401:146,4:AppTestCase.test_app_cp1252: Unable to import 'webtest'
F0401:158,4:AppTestCase.test_app_cp1252_blob: Unable to import 'webtest'
F0401:172,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest'
F0401:173,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest'


Presubmit checks took 16.3s to calculate.

[commit-bot: I haz the power, 2014-01-18 02:04:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stip@chromium.org/142243002/50001

[commit-bot: I haz the power, 2014-01-18 02:05:01]

Presubmit check for 142243002-50001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
nosetests failed!
Command nosetests --with-gae --gae-lib-root=/b/google_appengine returned
non-zero exit status 2
Usage: nosetests [options]

nosetests: error: no such option: --with-gae


Pylint (11 files) (6.96s) failed
************* Module app_test
F0401: 79,4:MainTestCase.test_main_page_redirect: Unable to import 'webtest'
F0401: 99,4:AppTestCase.test_app: Unable to import 'webtest'
F0401:110,4:AppTestCase.test_app_blob: Unable to import 'webtest'
F0401:121,4:AppTestCase.test_app_unicode: Unable to import 'webtest'
F0401:133,4:AppTestCase.test_app_unicode_blob: Unable to import 'webtest'
F0401:146,4:AppTestCase.test_app_cp1252: Unable to import 'webtest'
F0401:158,4:AppTestCase.test_app_cp1252_blob: Unable to import 'webtest'
F0401:172,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest'
F0401:173,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest'


Presubmit checks took 8.5s to calculate.

[commit-bot: I haz the power, 2014-01-18 02:06:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stip@chromium.org/142243002/50001

[commit-bot: I haz the power, 2014-01-18 02:07:41]

Presubmit check for 142243002-50001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
nosetests failed!
Command nosetests --with-gae --gae-lib-root=/b/google_appengine returned
non-zero exit status 1
EEEEEEE..FF......E.
======================================================================
ERROR: test_app (app_test.AppTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 99, in
test_app
    from webtest import TestApp
ImportError: No module named webtest
-------------------- >> begin captured logging << --------------------
root: WARNING: The datastore file stub is deprecated, and
will stop being the default in a future release.
Append the --use_sqlite flag to use the new SQLite stub.

You can port your existing data using the --port_sqlite_data flag or
purge your previous test data with --clear_datastore.

root: WARNING: Could not read datastore data from /tmp/nosegae.datastore
root: WARNING: Could not read search indexes from
/tmp/dev_appserver.searchindexes
root: WARNING: Could not initialize images API; you are likely missing the
Python "PIL" module. ImportError: No module named _imaging
root: DEBUG: Enabling django: []
root: DEBUG: Enabling Django version 1.2 at /b/google_appengine/lib/django-1.2
root: DEBUG: Enabling jinja2: ['_debugsupport', '_speedups']
root: DEBUG: Enabling markupsafe: ['_speedups']
root: DEBUG: Enabling setuptools: []
root: DEBUG: Third party package markupsafe was enabled in app.yaml but not
found on import. You may have to download and install it.
root: DEBUG: Third party package jinja2 was enabled in app.yaml but not found on
import. You may have to download and install it.
--------------------- >> end captured logging << ---------------------

======================================================================
ERROR: test_app_blob (app_test.AppTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 110, in
test_app_blob
    from webtest import TestApp
ImportError: No module named webtest

======================================================================
ERROR: test_app_bogus_query_string (app_test.AppTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 172, in
test_app_bogus_query_string
    from webtest import TestApp
ImportError: No module named webtest

======================================================================
ERROR: test_app_cp1252 (app_test.AppTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 146, in
test_app_cp1252
    from webtest import TestApp
ImportError: No module named webtest

======================================================================
ERROR: test_app_cp1252_blob (app_test.AppTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 158, in
test_app_cp1252_blob
    from webtest import TestApp
ImportError: No module named webtest

======================================================================
ERROR: test_app_unicode (app_test.AppTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 121, in
test_app_unicode
    from webtest import TestApp
ImportError: No module named webtest

======================================================================
ERROR: test_app_unicode_blob (app_test.AppTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 133, in
test_app_unicode_blob
    from webtest import TestApp
ImportError: No module named webtest

======================================================================
ERROR: test_main_page_redirect (app_test.MainTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 79, in
test_main_page_redirect
    from webtest import TestApp
ImportError: No module named webtest

======================================================================
FAIL: test_console_merger (app_test.ConsoleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 381, in
test_console_merger
    'Unexpected console output found')
AssertionError: Unexpected console output found
-------------------- >> begin captured logging << --------------------
root: DEBUG: save_page: content size is 32464
root: INFO: Saved and cached page with localpath surroundings
root: DEBUG: save_page: content size is 196
root: INFO: Saved and cached page with localpath
chromium.linux/console/categories
root: DEBUG: save_page: content size is 3667
root: INFO: Saved and cached page with localpath chromium.linux/console/summary
root: INFO: Saved and cached row with localpath chromium.linux/console/171895
root: DEBUG: content for latest_rev found in memcache
root: ERROR: get_and_cache_rowdata('latest_rev'): no matching localpath in
datastore
root: DEBUG: save_page: content size is 0
root: INFO: Saved and cached page with localpath chromium.mac/console/categories
root: DEBUG: save_page: content size is 4738
root: INFO: Saved and cached page with localpath chromium.mac/console/summary
root: INFO: Saved and cached row with localpath chromium.mac/console/171895
root: DEBUG: content for latest_rev found in memcache
root: DEBUG: save_page: content size is 0
root: INFO: Saved and cached page with localpath chromium.win/console/categories
root: DEBUG: save_page: content size is 7712
root: INFO: Saved and cached page with localpath chromium.win/console/summary
root: INFO: Saved and cached row with localpath chromium.win/console/171895
root: DEBUG: content for latest_rev found in memcache
root: DEBUG: save_page: content size is 335
root: INFO: Saved and cached page with localpath
chromium.memory/console/categories
root: DEBUG: save_page: content size is 4796
root: INFO: Saved and cached page with localpath chromium.memory/console/summary
root: INFO: Saved and cached row with localpath chromium.memory/console/171895
root: DEBUG: content for latest_rev found in memcache
root: DEBUG: save_page: content size is 66809
root: INFO: Saved and cached page with localpath merged_output
root: DEBUG: content for surroundings found in memcache
root: DEBUG: content for surroundings found in cache
root: DEBUG: content for latest_rev found in memcache
root: DEBUG: content for chromium.linux/console/summary found in memcache
root: DEBUG: content for chromium.linux/console/summary found in cache
root: DEBUG: content for chromium.linux/console/categories found in memcache
root: DEBUG: content for chromium.linux/console/categories found in cache
root: DEBUG: content for chromium.linux/console/171895 found in memcache
root: DEBUG: SawRevision: guessing at row ordering
root: DEBUG: content for chromium.mac/console/summary found in memcache
root: DEBUG: content for chromium.mac/console/summary found in cache
root: DEBUG: content for chromium.mac/console/categories found in memcache
root: DEBUG: content for chromium.mac/console/categories found in cache
root: DEBUG: content for chromium.mac/console/171895 found in memcache
root: DEBUG: content for chromium.win/console/summary found in memcache
root: DEBUG: content for chromium.win/console/summary found in cache
root: DEBUG: content for chromium.win/console/categories found in memcache
root: DEBUG: content for chromium.win/console/categories found in cache
root: DEBUG: content for chromium.win/console/171895 found in memcache
root: DEBUG: content for chromium.memory/console/summary found in memcache
root: DEBUG: content for chromium.memory/console/summary found in cache
root: DEBUG: content for chromium.memory/console/categories found in memcache
root: DEBUG: content for chromium.memory/console/categories found in cache
root: DEBUG: content for chromium.memory/console/171895 found in memcache
root: INFO: console_merger: saving merged console
root: DEBUG: content for chromium/console found in datastore
root: DEBUG: save_page: content size is 32376
root: INFO: Saved and cached page with localpath chromium/console
root: DEBUG: content for chromium/console found in memcache
root: DEBUG: content for chromium/console found in cache
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: test_console_merger_splitrevs (app_test.ConsoleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/chromium-build/app_test.py", line 431, in
test_console_merger_splitrevs
    'Unexpected console output found')
AssertionError: Unexpected console output found
-------------------- >> begin captured logging << --------------------
root: DEBUG: save_page: content size is 32464
root: INFO: Saved and cached page with localpath surroundings
root: DEBUG: save_page: content size is 196
root: INFO: Saved and cached page with localpath
chromium.linux/console/categories
root: DEBUG: save_page: content size is 3667
root: INFO: Saved and cached page with localpath chromium.linux/console/summary
root: INFO: Saved and cached row with local…
(message too large)

[commit-bot: I haz the power, 2014-01-18 02:09:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stip@chromium.org/142243002/50001

[commit-bot: I haz the power, 2014-01-18 02:10:11]

Change committed as 245717

[ghost stip (do not use), 2014-01-18 02:28:47]

sweet!