Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 142243002: Fix presubmit.py tests. (Closed)

Created:
5 years, 5 months ago by ghost stip (do not use)
Modified:
5 years, 5 months ago
Reviewers:
cmp, agable
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

Fix presubmit.py tests. Presubmit tests in chromium-build have been broken since https://codereview.chromium.org/23033018. This fixes that, and adds some info about how to change the test data. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245717

Patch Set 1 #

Patch Set 2 : Remove change in test logic. #

Patch Set 3 : Remove spurious spaces. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M app_test.py View 1 2 4 chunks +8 lines, -0 lines 1 comment Download
M tests/test_console_handler/console-expected.html View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/test_console_handler_utf8/console-expected.html View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/test_fetch_console/expected.html View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ghost stip (do not use)
fix broken presubmit tests
5 years, 5 months ago (2014-01-18 01:19:38 UTC) #1
cmp
lgtm https://codereview.chromium.org/142243002/diff/50001/app_test.py File app_test.py (right): https://codereview.chromium.org/142243002/diff/50001/app_test.py#newcode219 app_test.py:219: # 'retrain' the test expectations. Thanks for commenting ...
5 years, 5 months ago (2014-01-18 01:46:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/142243002/50001
5 years, 5 months ago (2014-01-18 01:54:04 UTC) #3
commit-bot: I haz the power
Presubmit check for 142243002-50001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 5 months ago (2014-01-18 01:54:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/142243002/50001
5 years, 5 months ago (2014-01-18 02:04:43 UTC) #5
commit-bot: I haz the power
Presubmit check for 142243002-50001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 5 months ago (2014-01-18 02:05:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/142243002/50001
5 years, 5 months ago (2014-01-18 02:06:58 UTC) #7
commit-bot: I haz the power
Presubmit check for 142243002-50001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 5 months ago (2014-01-18 02:07:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/142243002/50001
5 years, 5 months ago (2014-01-18 02:09:47 UTC) #9
commit-bot: I haz the power
Change committed as 245717
5 years, 5 months ago (2014-01-18 02:10:11 UTC) #10
ghost stip (do not use)
5 years, 5 months ago (2014-01-18 02:28:47 UTC) #11
Message was sent while issue was closed.
sweet!

Powered by Google App Engine
This is Rietveld 408576698