Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: app_test.py

Issue 142243002: Fix presubmit.py tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/chromium-build
Patch Set: Remove spurious spaces. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/test_console_handler/console-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app_test.py
diff --git a/app_test.py b/app_test.py
index a24e144c438afc7a334baff29285f4d719970016..a6cece4c5157d54ed0ad42999f03ecf125751fd0 100644
--- a/app_test.py
+++ b/app_test.py
@@ -215,6 +215,8 @@ class ConsoleTestCase(GaeTestCase):
remoteurl='http://build.chromium.org/p/chromium/console',
page_data=page_data)
# Uncomment if deeper inspection is needed of the returned console.
+ # This is also useful if changing the site layout and you need to
+ # 'retrain' the test expectations.
cmp 2014/01/18 01:46:07 Thanks for commenting this. It was actually the m
# with open(os.path.join(test_dir, 'console-expected.html'), 'w') as fh:
# fh.write(actual_console['content'])
self.assertEquals(expected_console, actual_console['content'],
@@ -244,6 +246,8 @@ class ConsoleTestCase(GaeTestCase):
remoteurl='http://build.chromium.org/p/chromium/console',
page_data=page_data)
# Uncomment if deeper inspection is needed of the returned console.
+ # This is also useful if changing the site layout and you need to
+ # 'retrain' the test expectations.
# with open(os.path.join(test_dir, 'console-expected.html'), 'w') as fh:
# fh.write(actual_console['content'])
self.assertEquals(expected_console, actual_console['content'],
@@ -449,6 +453,8 @@ class FetchTestCase(GaeTestCase):
fetch_url=fetch_url)
page = app.get_and_cache_pagedata('chromium/console')
# Uncomment if deeper inspection is needed of the returned console.
+ # This is also useful if changing the site layout and you need to
+ # 'retrain' the test expectations.
# with open(os.path.join(test_dir, 'expected.html'), 'w') as fh:
# fh.write(page['content'])
self.assertEquals(expected_content, page['content'])
@@ -471,6 +477,8 @@ class FetchTestCase(GaeTestCase):
fetch_url=fetch_url)
page = app.get_and_cache_pagedata('chromium/console')
# Uncomment if deeper inspection is needed of the returned console.
+ # This is also useful if changing the site layout and you need to
+ # 'retrain' the test expectations.
# with open(os.path.join(test_dir, 'expected.html'), 'w') as fh:
# fh.write(page['content'])
self.assertEquals('interface', page['body_class'])
« no previous file with comments | « no previous file | tests/test_console_handler/console-expected.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698