Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1422393002: Fix crash when following a link opening a new tab/window. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when following a link opening a new tab/window. Issue http://crrev.com/1408643002 removed the check for NULL entry when accessing the virtual URL. It is possible to end up with such an entry when following a link opening a new tab/window. Fix the crash by checking that GetPossiblyPendingEntryAtIndex() returns a non-NULL entry. BUG=548572 Committed: https://crrev.com/bf61f1832c367260d70d96a92fefc31fd6f987e9 Cr-Commit-Position: refs/heads/master@{#356579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
sdefresne
I think this should be enough as this is the only code path that checked ...
5 years, 1 month ago (2015-10-28 16:37:49 UTC) #2
Nicolas Zea
lgtm
5 years, 1 month ago (2015-10-28 16:54:16 UTC) #3
Nicolas Zea
Thanks for fixing this so quick btw!
5 years, 1 month ago (2015-10-28 16:55:21 UTC) #4
Nicolas Zea
On 2015/10/28 16:55:21, Nicolas Zea wrote: > Thanks for fixing this so quick btw! I'll ...
5 years, 1 month ago (2015-10-28 16:55:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422393002/1
5 years, 1 month ago (2015-10-28 16:58:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 17:57:31 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 17:58:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf61f1832c367260d70d96a92fefc31fd6f987e9
Cr-Commit-Position: refs/heads/master@{#356579}

Powered by Google App Engine
This is Rietveld 408576698