Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 1422383003: [Extensions] Make handler_function a hidden property (Closed)

Created:
3 years, 9 months ago by Devlin
Modified:
3 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Make handler_function a hidden property Fix the glitch and add a test. BUG=548273 Committed: https://crrev.com/a5ecbc86a598e29ce3a2424c9c5386bfba4e9b74 Cr-Commit-Position: refs/heads/master@{#356985}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/bindings/handler_function_type_checking.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
M extensions/renderer/object_backed_native_handler.cc View 1 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Devlin
3 years, 9 months ago (2015-10-29 22:59:05 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2015-10-29 23:03:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422383003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422383003/40001
3 years, 9 months ago (2015-10-29 23:07:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
3 years, 9 months ago (2015-10-29 23:41:38 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2015-10-29 23:42:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5ecbc86a598e29ce3a2424c9c5386bfba4e9b74
Cr-Commit-Position: refs/heads/master@{#356985}

Powered by Google App Engine
This is Rietveld 408576698