Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1422363007: Fix inspector crash after inspecting a link tag (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inspector crash after inspecting a link tag In r357842 text-decoration handling was converted to use CSSParserTokens, however mistakenly m_currentShorthand was set even in the case text-decoration falls back to non-shorthand behavior, causing an ASSERT later. This patch resets the m_currentShorthand when we fall-back to non-shorthand behavior, fixing the crash. BUG=551638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
rwlbuis
PTAL. Sadly I could not find a way to create a layout test for this, ...
5 years, 1 month ago (2015-11-05 19:54:03 UTC) #3
rwlbuis
5 years, 1 month ago (2015-11-05 21:32:50 UTC) #4
On 2015/11/05 19:54:03, rwlbuis wrote:
> PTAL. Sadly I could not find a way to create a layout test for this, but it
does
> fix the crash, verified by testing manually.

Will incorporate this fix in bringing the reverted patch back:
https://codereview.chromium.org/1405273005/.

Powered by Google App Engine
This is Rietveld 408576698