Add UMULL to ARM integrated assembler.

Add UMULL to ARM integrated assembler.

Also formatted IceCfg.cpp, since it needed it.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=430e84471a54f6e5a1727054be28680e489cf28d

[Karl, 2015-11-06 21:52:20]

Description was changed from

==========
Add UMULL to ARM integrated assembler.

Also formatted IceCfg.cpp, since it needed it.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add UMULL to ARM integrated assembler.

Also formatted IceCfg.cpp, since it needed it.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-11-06 21:52:21]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-11-06 22:26:42]

lgtm

https://codereview.chromium.org/1422253003/diff/1/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1422253003/diff/1/src/IceAssemblerARM32.cpp#n...
src/IceAssemblerARM32.cpp:1052: void AssemblerARM32::umull(const Operand
*OpRdLo, const Operand *OpRdHi,
Is this a situation where you would comment out umull() in assembler_arm.cc ?

https://codereview.chromium.org/1422253003/diff/1/src/IceAssemblerARM32.cpp#n...
src/IceAssemblerARM32.cpp:1072: llvm::report_fatal_error("Sdiv instruction
unpredictable on pc");
sdiv?

[Karl, 2015-11-09 20:16:24]

Committed patchset #2 (id:20001) manually as
430e84471a54f6e5a1727054be28680e489cf28d (presubmit successful).

[Karl, 2015-11-09 20:16:37]

https://codereview.chromium.org/1422253003/diff/1/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1422253003/diff/1/src/IceAssemblerARM32.cpp#n...
src/IceAssemblerARM32.cpp:1052: void AssemblerARM32::umull(const Operand
*OpRdLo, const Operand *OpRdHi,
On 2015/11/06 22:26:42, stichnot wrote:
> Is this a situation where you would comment out umull() in assembler_arm.cc ?

Yes. I forgot that. Commenting appropriate entries.

https://codereview.chromium.org/1422253003/diff/1/src/IceAssemblerARM32.cpp#n...
src/IceAssemblerARM32.cpp:1072: llvm::report_fatal_error("Sdiv instruction
unpredictable on pc");
On 2015/11/06 22:26:42, stichnot wrote:
> sdiv?

Need to improve my cut/paste skills! Fixing.