Issue 1422253002: Merge to XFA: Type check the m_pShadingObj before assuming it's a stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1422253002: Merge to XFA: Type check the m_pShadingObj before assuming it's a stream. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Type check the m_pShadingObj before assuming it's a stream. The m_pShadingObj can be a stream or a dictionary depending on how it's used. This CL adds some simple type checking to make sure that the type of the object matches what we expect. BUG=chromium:547706 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1421973004 . (cherry picked from commit 4ef782ab57979add3e3910d6bcfde6ef59f65724) Committed: https://pdfium.googlesource.com/pdfium/+/431ba1865443e5cba4dabc74e61ece4daba11b5b

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -0 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	core/src/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	testing/resources/bug_547706.in	View	1 chunk	+43 lines, -0 lines	0 comments	Download
A	testing/resources/bug_547706.pdf	View	1 chunk	+55 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

dsinclair

Committed patchset #1 (id:1) manually as 431ba1865443e5cba4dabc74e61ece4daba11b5b (presubmit successful).

5 years, 1 month ago (2015-10-27 16:19:17 UTC) #1

Message was sent while issue was closed.

lgtm