Type check the m_pShadingObj before assuming it's a stream.

Type check the m_pShadingObj before assuming it's a stream.

The m_pShadingObj can be a stream or a dictionary depending on how it's used.
This CL adds some simple type checking to make sure that the type of the
object matches what we expect.

BUG=chromium:547706
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/4ef782ab57979add3e3910d6bcfde6ef59f65724

[dsinclair, 2015-10-27 13:41:49]

Description was changed from

==========
Type check the m_pShadingObj before assuming it's a stream.

The m_pShadingObj can be a stream or a dictionary depending on how it's used.
This CL adds some simple type checking to make sure that we type of the
object matches what we expect.

BUG=chromium:547706
==========

to

==========
Type check the m_pShadingObj before assuming it's a stream.

The m_pShadingObj can be a stream or a dictionary depending on how it's used.
This CL adds some simple type checking to make sure that the type of the
object matches what we expect.

BUG=chromium:547706
==========

[dsinclair, 2015-10-27 13:42:19]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2015-10-27 13:42:20]

PTAL.

Patch Set 1 was the reverted CL. Patch set two is the new approach.

[Tom Sepez, 2015-10-27 16:04:00]

lgtm

https://codereview.chromium.org/1421973004/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp (right):

https://codereview.chromium.org/1421973004/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp:146: if
(!ToStream(m_pShadingObj))
nit: combine with previous if.

[dsinclair, 2015-10-27 16:08:15]

https://codereview.chromium.org/1421973004/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp (right):

https://codereview.chromium.org/1421973004/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp:146: if
(!ToStream(m_pShadingObj))
On 2015/10/27 16:04:00, Tom Sepez wrote:
> nit: combine with previous if.

Done.

[dsinclair, 2015-10-27 16:08:24]

Committed patchset #3 (id:40001) manually as
4ef782ab57979add3e3910d6bcfde6ef59f65724 (presubmit successful).