Issue 1422073003: Fix crash in source_package.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1422073003: Fix crash in source_package.py (Closed)

Created:
5 years, 1 month ago by Sam Clegg

Modified:
5 years, 1 month ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/naclports.git@master

Target Ref:
refs/heads/master

Project:
naclports

Visibility:
Public.

Fix crash in source_package.py install_package was recently split into its own patch module but this use was missed. Add a unittest to cover this code. R=binji@chromium.org Committed: https://chromium.googlesource.com/external/naclports/+/f36bd685a16b733fa851768c4c92e4ea6e2687d8

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	lib/naclports/source_package.py	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	lib/naclports/tests/test_source_package.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Total messages: 4 (1 generated)

Sam Clegg

5 years, 1 month ago (2015-10-26 19:34:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f36bd685a16b733fa851768c4c92e4ea6e2687d8 (presubmit successful).