Switch from using 'nacl_main' to 'main' entry point

Switch from using 'nacl_main' to 'main' entry point

Also EnableCliMain function which ports can use
to enable use of cli_main/nacl_spawn.  This allows
is to modify the linker flags/libraries in a single
location which will be useful for adding emscripten
support.

Committed: https://chromium.googlesource.com/external/naclports/+/55ead6d51c8490331905b239951aeb64f2cd47c7

[Sam Clegg, 2015-10-26 19:24:00]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 19:24:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/20001

[commit-bot: I haz the power, 2015-10-26 19:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 19:27:58]

Dry run: Try jobs failed on following builders:
  naclports-presubmit on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-presubmit/build...)

[Sam Clegg, 2015-10-26 19:37:30]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[Sam Clegg, 2015-10-27 19:13:48]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-27 19:14:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/40001

[Sam Clegg, 2015-10-27 19:15:23]

Description was changed from

==========
Switch from using 'nacl_main' to 'main' entry point
==========

to

==========
Switch from using 'nacl_main' to 'main' entry point

Also EnableCliMain function which ports can use
to enable use of cli_main/nacl_spawn.  This allows
is to modify the linker flags/libraries in a single
location which will be useful for adding emscripten
support.
==========

[commit-bot: I haz the power, 2015-10-27 20:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 20:57:21]

Dry run: Try jobs failed on following builders:
  naclports-linux-clang-0 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-0/b...)

[binji, 2015-10-27 21:52:38]

lgtm, wondering about when you don't use EnableCliMain though

https://codereview.chromium.org/1417223003/diff/40001/ports/avrdude/nacl.patch
File ports/avrdude/nacl.patch (left):

https://codereview.chromium.org/1417223003/diff/40001/ports/avrdude/nacl.patc...
ports/avrdude/nacl.patch:9: +	$(AM_V_CCLD)$(avrdude_LINK) $(avrdude_OBJECTS)
$(EXTRA_LIBS) $(avrdude_LDADD) $(LIBS)
remove definition of EXTRA_LIBS too?

https://codereview.chromium.org/1417223003/diff/40001/ports/binutils-2.25/bui...
File ports/binutils-2.25/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/binutils-2.25/bui...
ports/binutils-2.25/build.sh:9: export EXTRA_LIBS="${NACL_CLI_MAIN_LIB}"
can't use EnableCliMain here?

https://codereview.chromium.org/1417223003/diff/40001/ports/curl/build.sh
File ports/curl/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/curl/build.sh#new...
ports/curl/build.sh:11: export EXTRA_LIBS="${NACL_CLI_MAIN_LIB}"
Why not EnableCliMain?

https://codereview.chromium.org/1417223003/diff/40001/ports/font-util/build.sh
File ports/font-util/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/font-util/build.s...
ports/font-util/build.sh:11: export LIBS="${NACL_CLI_MAIN_LIB}"
here too

https://codereview.chromium.org/1417223003/diff/40001/ports/gforth/build.sh
File ports/gforth/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/gforth/build.sh#n...
ports/gforth/build.sh:30: export LIBS+=" ${NACL_CLI_MAIN_LIB}"
or here

https://codereview.chromium.org/1417223003/diff/40001/ports/tk/build.sh
File ports/tk/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/tk/build.sh#newcode7
ports/tk/build.sh:7: NACLPORTS_LIBS+=" -lX11 -lxcb -lXau ${NACL_CLI_MAIN_LIB}"
here too

https://codereview.chromium.org/1417223003/diff/40001/ports/toybox/build.sh
File ports/toybox/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/toybox/build.sh#n...
ports/toybox/build.sh:12: NACLPORTS_LDFLAGS+=" ${NACL_CLI_MAIN_LIB}"
and here

https://codereview.chromium.org/1417223003/diff/40001/ports/twm/build.sh
File ports/twm/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/twm/build.sh#newc...
ports/twm/build.sh:8: -lXext -lXmu -lSM -lICE -lXt -lX11 -lxcb -lXau
${NACL_CLI_MAIN_LIB}"
ditto

[Sam Clegg, 2015-10-28 16:18:05]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-28 16:18:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/60001

[Sam Clegg, 2015-10-28 17:06:31]

https://codereview.chromium.org/1417223003/diff/40001/ports/avrdude/nacl.patch
File ports/avrdude/nacl.patch (left):

https://codereview.chromium.org/1417223003/diff/40001/ports/avrdude/nacl.patc...
ports/avrdude/nacl.patch:9: +	$(AM_V_CCLD)$(avrdude_LINK) $(avrdude_OBJECTS)
$(EXTRA_LIBS) $(avrdude_LDADD) $(LIBS)
On 2015/10/27 21:52:38, binji wrote:
> remove definition of EXTRA_LIBS too?

It was removed from ports/avrdude/build.sh.  It was never defined in the
Makefile.

https://codereview.chromium.org/1417223003/diff/40001/ports/binutils-2.25/bui...
File ports/binutils-2.25/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/binutils-2.25/bui...
ports/binutils-2.25/build.sh:9: export EXTRA_LIBS="${NACL_CLI_MAIN_LIB}"
On 2015/10/27 21:52:38, binji wrote:
> can't use EnableCliMain here?

Done.

https://codereview.chromium.org/1417223003/diff/40001/ports/curl/build.sh
File ports/curl/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/curl/build.sh#new...
ports/curl/build.sh:11: export EXTRA_LIBS="${NACL_CLI_MAIN_LIB}"
On 2015/10/27 21:52:38, binji wrote:
> Why not EnableCliMain?

The comment above explains why.

https://codereview.chromium.org/1417223003/diff/40001/ports/font-util/build.sh
File ports/font-util/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/font-util/build.s...
ports/font-util/build.sh:11: export LIBS="${NACL_CLI_MAIN_LIB}"
On 2015/10/27 21:52:38, binji wrote:
> here too

Done.

https://codereview.chromium.org/1417223003/diff/40001/ports/gforth/build.sh
File ports/gforth/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/gforth/build.sh#n...
ports/gforth/build.sh:30: export LIBS+=" ${NACL_CLI_MAIN_LIB}"
On 2015/10/27 21:52:38, binji wrote:
> or here

Done.

https://codereview.chromium.org/1417223003/diff/40001/ports/tk/build.sh
File ports/tk/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/tk/build.sh#newcode7
ports/tk/build.sh:7: NACLPORTS_LIBS+=" -lX11 -lxcb -lXau ${NACL_CLI_MAIN_LIB}"
On 2015/10/27 21:52:38, binji wrote:
> here too

Done.

https://codereview.chromium.org/1417223003/diff/40001/ports/toybox/build.sh
File ports/toybox/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/toybox/build.sh#n...
ports/toybox/build.sh:12: NACLPORTS_LDFLAGS+=" ${NACL_CLI_MAIN_LIB}"
On 2015/10/27 21:52:38, binji wrote:
> and here

Done.

https://codereview.chromium.org/1417223003/diff/40001/ports/twm/build.sh
File ports/twm/build.sh (right):

https://codereview.chromium.org/1417223003/diff/40001/ports/twm/build.sh#newc...
ports/twm/build.sh:8: -lXext -lXmu -lSM -lICE -lXt -lX11 -lxcb -lXau
${NACL_CLI_MAIN_LIB}"
On 2015/10/27 21:52:38, binji wrote:
> ditto

Done.

[commit-bot: I haz the power, 2015-10-28 17:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 17:52:50]

Dry run: Try jobs failed on following builders:
  naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...)

[Sam Clegg, 2015-10-28 19:34:12]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-10-28 19:34:12]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1417223003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-10-28 19:34:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/80001

[commit-bot: I haz the power, 2015-10-28 21:20:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 21:20:09]

Try jobs failed on following builders:
  naclports-linux-pnacl-1 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-1/b...)

[Sam Clegg, 2015-10-29 01:33:31]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-10-29 01:33:32]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1417223003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-10-29 01:33:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/100001

[commit-bot: I haz the power, 2015-10-29 03:56:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 03:56:39]

Try jobs failed on following builders:
  naclports-linux-pnacl-2 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-2/b...)

[Sam Clegg, 2015-10-29 04:50:29]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-10-29 04:50:29]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1417223003/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-10-29 04:50:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/120001

[commit-bot: I haz the power, 2015-10-29 09:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 09:20:27]

Try jobs failed on following builders:
  naclports-linux-glibc-3 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-3/b...)

[Sam Clegg, 2015-10-29 16:38:13]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-10-29 16:38:13]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1417223003/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-10-29 16:38:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/140001

[Sam Clegg, 2015-10-30 00:30:30]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-10-30 00:30:30]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1417223003/#ps160001
(title: " ")

[commit-bot: I haz the power, 2015-10-30 00:30:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/160001

[commit-bot: I haz the power, 2015-10-30 03:01:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 03:01:21]

Try jobs failed on following builders:
  naclports-linux-glibc-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-4/b...)

[Sam Clegg, 2015-10-30 03:48:10]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-10-30 03:48:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/160001

[commit-bot: I haz the power, 2015-10-30 09:25:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 09:25:14]

Try jobs failed on following builders:
  naclports-linux-glibc-3 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-3/b...)

[Sam Clegg, 2015-10-30 22:22:46]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-10-30 22:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1417223003/#ps180001
(title: " ")

[commit-bot: I haz the power, 2015-10-30 22:23:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/180001

[commit-bot: I haz the power, 2015-10-31 04:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-31 04:23:43]

Try jobs failed on following builders:
  naclports-linux-clang-1 on tryserver.nacl (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-1/b...)
  naclports-linux-glibc-1 on tryserver.nacl (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-1/b...)

[Sam Clegg, 2015-10-31 18:14:25]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-10-31 18:14:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/180001

[commit-bot: I haz the power, 2015-10-31 22:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-31 22:24:09]

Exceeded global retry quota

[Sam Clegg, 2015-11-02 17:16:48]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-11-02 17:17:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417223003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417223003/180001

[commit-bot: I haz the power, 2015-11-02 22:35:51]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/external/naclports/+/55ead6d51c8490331905b2...