MD Settings: Simplify settings-dropdown-menu

chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.html
diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
index c06182659b71fc3bd33cb84abb182de40f4d5a65..304ccd9bcae4a5855637b1a6ff26eca989d55251 100644
--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
@@ -3,20 +3,23 @@
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
+<link rel="import" href="chrome://md-settings/prefs/pref_util.html">
 
 <dom-module id="settings-dropdown-menu">
   <link rel="import" type="css"
       href="chrome://md-settings/settings_page/settings_page.css">
   <template>
-    <paper-dropdown-menu id="dropdownMenu"
-        label="[[menuLabel_]]" disabled>
-      <paper-menu class="dropdown-content" selected="{{selected_}}">
+    <paper-dropdown-menu id="dropdownMenu" label="[[menuLabel_]]"
+        on-iron-select="onSelect_" disabled="[[disabled]]">
+      <paper-menu class="dropdown-content" selected="{{selected_}}"
+          attr-for-selected="data-value">
         <template is="dom-repeat" items="[[menuOptions]]">
-          <paper-item>[[item.1]]</paper-item>
-        </template>
-        <template is="dom-if" if="[[showNotFoundValue_]]">
-          <paper-item>[[i18n('custom')]]</paper-item>
+          <paper-item data-value$="[[item.0]]">[[item.1]]</paper-item>
         </template>
+        <paper-item data-value$="[[notFoundValue_]]"
+            hidden$="[[!showNotFoundItem_]]">

[michaelpg, 2015/11/17 05:08:56]

In light of recent performance discussions, maybe <dom-if> is more performant
than a hidden item here, but A) it's tricky to get right because the dom-if
might not be updated until after the paper-menu-button text has been set, and B)
it's just one item in a menu with many items.

[stevenjb, 2015/11/17 18:19:23]

Agreed. We should focus on discluding cards/sections with complex dropdown menus
from the main pages instead since they are going to be fairly expensive
regardless.

+          [[i18n('custom')]]
+        </paper-item>
       </paper-menu>
     </paper-dropdown-menu>
   </template>