Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Issue 1422023012: MD Settings: Simplify settings-dropdown-menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix updateSelected Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">
5 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 5 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
6 <link rel="import" href="chrome://md-settings/prefs/pref_util.html">
6 7
7 <dom-module id="settings-dropdown-menu"> 8 <dom-module id="settings-dropdown-menu">
8 <link rel="import" type="css" 9 <link rel="import" type="css"
9 href="chrome://md-settings/settings_page/settings_page.css"> 10 href="chrome://md-settings/settings_page/settings_page.css">
10 <template> 11 <template>
11 <paper-dropdown-menu id="dropdownMenu" 12 <paper-dropdown-menu id="dropdownMenu" label="[[menuLabel_]]"
12 label="[[menuLabel_]]" disabled> 13 on-iron-select="onSelect_" disabled="[[disabled]]">
13 <paper-menu class="dropdown-content" selected="{{selected_}}"> 14 <paper-menu class="dropdown-content" selected="{{selected_}}"
15 attr-for-selected="data-value">
14 <template is="dom-repeat" items="[[menuOptions]]"> 16 <template is="dom-repeat" items="[[menuOptions]]">
15 <paper-item>[[item.1]]</paper-item> 17 <paper-item data-value$="[[item.0]]">[[item.1]]</paper-item>
16 </template> 18 </template>
17 <template is="dom-if" if="[[showNotFoundValue_]]"> 19 <paper-item data-value$="[[notFoundValue_]]"
18 <paper-item>[[i18n('custom')]]</paper-item> 20 hidden$="[[!showNotFoundItem_]]">
michaelpg 2015/11/17 05:08:56 In light of recent performance discussions, maybe
stevenjb 2015/11/17 18:19:23 Agreed. We should focus on discluding cards/sectio
19 </template> 21 [[i18n('custom')]]
22 </paper-item>
20 </paper-menu> 23 </paper-menu>
21 </paper-dropdown-menu> 24 </paper-dropdown-menu>
22 </template> 25 </template>
23 <script src="settings_dropdown_menu.js"></script> 26 <script src="settings_dropdown_menu.js"></script>
24 </dom-module> 27 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698