util/win/process_info.h - Issue 1422023010: win: Use signed int as the integer representation of HANDLEs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/win/process_info.h

Issue 1422023010: win: Use signed int as the integer representation of HANDLEs (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/win/process_info.h

diff --git a/util/win/process_info.h b/util/win/process_info.h

index 49a6f3549b06cbdcca6e4e56518455eb87e04fa2..fb1b8b3e0ac6783e3b85e594d976277d79b269f9 100644

--- a/util/win/process_info.h

+++ b/util/win/process_info.h

@@ -58,7 +58,7 @@ class ProcessInfo {

std::wstring type_name;

//! \brief The handle's value.

- uint32_t handle;

+ int handle;

//! \brief The attributes for the handle, e.g. `OBJ_INHERIT`,

//! `OBJ_CASE_INSENSITIVE`, etc.

« util/win/handle.h ('K') | « util/win/handle.h ('k') | util/win/process_info_test.cc » ('j') | util/win/registration_protocol_win.h » ('J')