Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: util/win/process_info.h

Issue 1422023010: win: Use signed int as the integer representation of HANDLEs (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 }; 51 };
52 52
53 struct Handle { 53 struct Handle {
54 Handle(); 54 Handle();
55 ~Handle(); 55 ~Handle();
56 56
57 //! \brief A string representation of the handle's type. 57 //! \brief A string representation of the handle's type.
58 std::wstring type_name; 58 std::wstring type_name;
59 59
60 //! \brief The handle's value. 60 //! \brief The handle's value.
61 uint32_t handle; 61 int handle;
62 62
63 //! \brief The attributes for the handle, e.g. `OBJ_INHERIT`, 63 //! \brief The attributes for the handle, e.g. `OBJ_INHERIT`,
64 //! `OBJ_CASE_INSENSITIVE`, etc. 64 //! `OBJ_CASE_INSENSITIVE`, etc.
65 uint32_t attributes; 65 uint32_t attributes;
66 66
67 //! \brief The `ACCESS_MASK` for the handle in this process. 67 //! \brief The `ACCESS_MASK` for the handle in this process.
68 //! 68 //!
69 //! See 69 //! See
70 //! http://blogs.msdn.com/b/openspecification/archive/2010/04/01/about-the-a ccess-mask-structure.aspx 70 //! http://blogs.msdn.com/b/openspecification/archive/2010/04/01/about-the-a ccess-mask-structure.aspx
71 //! for more information. 71 //! for more information.
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 //! 193 //!
194 //! This is a free function for testing, but prefer 194 //! This is a free function for testing, but prefer
195 //! ProcessInfo::GetReadableRanges(). 195 //! ProcessInfo::GetReadableRanges().
196 std::vector<CheckedRange<WinVMAddress, WinVMSize>> GetReadableRangesOfMemoryMap( 196 std::vector<CheckedRange<WinVMAddress, WinVMSize>> GetReadableRangesOfMemoryMap(
197 const CheckedRange<WinVMAddress, WinVMSize>& range, 197 const CheckedRange<WinVMAddress, WinVMSize>& range,
198 const std::vector<MEMORY_BASIC_INFORMATION64>& memory_info); 198 const std::vector<MEMORY_BASIC_INFORMATION64>& memory_info);
199 199
200 } // namespace crashpad 200 } // namespace crashpad
201 201
202 #endif // CRASHPAD_UTIL_WIN_PROCESS_INFO_H_ 202 #endif // CRASHPAD_UTIL_WIN_PROCESS_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698