win: Use signed int as the integer representation of HANDLEs

util/win/handle.h

Index: util/win/handle.h
diff --git a/util/win/handle.h b/util/win/handle.h
index c5a96cae9e7219580e3814881b86787f838244ef..8a63069069ce9548864bae720690a3aca95a86ed 100644
--- a/util/win/handle.h
+++ b/util/win/handle.h
@@ -21,17 +21,17 @@ namespace crashpad {
 
 //! \brief Converts a `HANDLE` to an `int`.
 //!
-//! `HANDLE` is a `typedef` for `void *`, but `HANDLE` values aren’t necessarily
-//! pointers to anything. Only 32 bits of shareable `HANDLE`s are significant,
-//! even in 64-bit processes on 64-bit operating systems. See <a
+//! `HANDLE` is a `typedef` for `void *`, but kernel `HANDLE` values aren’t
+//! pointers to anything. Only 32 bits of kernel `HANDLE`s are significant, even

[scottmg, 2015/11/06 18:33:22]

Ah, I meant to mention "shareable" in the last change, good stuff.

[Mark Mentovai, 2015/11/06 18:36:27]

scottmg wrote:
Yeah, yesterday, I was kind of struggling with the best way to express this
while making it clear that it didn’t apply to things like HMODULE. Then it hit
me this morning!

+//! in 64-bit processes on 64-bit operating systems. See <a
 //! href="https://msdn.microsoft.com/en-us/library/windows/desktop/aa384203">Interprocess
 //! Communication Between 32-bit and 64-bit Applications</a>.
 //!
-//! This function safely converts a shareable `HANDLE` to an `int` similarly to
-//! a cast operation. It checks that the operation can be performed safely, and
+//! This function safely converts a kernel `HANDLE` to an `int` similarly to a
+//! cast operation. It checks that the operation can be performed safely, and
 //! aborts execution if it cannot.
 //!
-//! \param[in] handle The shareable `HANDLE` to convert.
+//! \param[in] handle The kernel `HANDLE` to convert.
 //!
 //! \return An equivalent `int`, truncated (if necessary) from \a handle. If
 //!     truncation would have resulted in an `int` that could not be converted
@@ -42,20 +42,20 @@ int HandleToInt(HANDLE handle);
 
 //! \brief Converts an `int` to an `HANDLE`.
 //!
-//! `HANDLE` is a `typedef` for `void *`, but `HANDLE` values aren’t necessarily
-//! pointers to anything. Only 32 bits of shareable `HANDLE`s are significant,
-//! even in 64-bit processes on 64-bit operating systems. See <a
+//! `HANDLE` is a `typedef` for `void *`, but kernel `HANDLE` values aren’t
+//! pointers to anything. Only 32 bits of kernel `HANDLE`s are significant, even
+//! in 64-bit processes on 64-bit operating systems. See <a
 //! href="https://msdn.microsoft.com/en-us/library/windows/desktop/aa384203">Interprocess
 //! Communication Between 32-bit and 64-bit Applications</a>.
 //!
-//! This function safely convert an `int` to a shareable `HANDLE` similarly to a
+//! This function safely convert an `int` to a kernel `HANDLE` similarly to a
 //! cast operation.
 //!
 //! \param[in] handle_int The `int` to convert. This must have been produced by
 //!     HandleToInt(), possibly in a different process.
 //!
-//! \return An equivalent shareable `HANDLE`, sign-extended (if necessary) from
-//!     \a handle_int.
+//! \return An equivalent kernel `HANDLE`, sign-extended (if necessary) from \a
+//!     handle_int.
 //!
 //! \sa HandleToInt()
 HANDLE IntToHandle(int handle_int);