Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: test/win/win_child_process.cc

Issue 1422023010: win: Use signed int as the integer representation of HANDLEs (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/win/handle.h » ('j') | util/win/handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/win_child_process.cc
diff --git a/test/win/win_child_process.cc b/test/win/win_child_process.cc
index 7d179337277ecbf06cde175145fe66ff942d1674..fdebfbcd369a585315a32a8e77e94e0095cf9d48 100644
--- a/test/win/win_child_process.cc
+++ b/test/win/win_child_process.cc
@@ -150,9 +150,13 @@ WinChildProcess::WinChildProcess() {
// values are passed to the child on the command line.
std::string left, right;
CHECK(SplitString(switch_value, '|', &left, &right));
+
+ // left and right were formatted as 0x%x, so they need to be converted as
+ // unsigned ints.
unsigned int write, read;
CHECK(StringToNumber(left, &write));
CHECK(StringToNumber(right, &read));
+
pipe_write_.reset(IntToHandle(write));
pipe_read_.reset(IntToHandle(read));
« no previous file with comments | « no previous file | util/win/handle.h » ('j') | util/win/handle.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698