Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422023003: Cosmetic portion of reverted "Fix ClipMaskManager's SW-fallback logic" CL (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@mdb-simplify-cmm-2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cosmetic portion of reverted "Fix ClipMaskManager's SW-fallback logic" CL This CL isolates the cosmetic portion so the functional portion is clearer. It relies on https://codereview.chromium.org/1412883005/ (Fix ClipMaskManager's SW-fallback logic (take 2)) Committed: https://skia.googlesource.com/skia/+/cf10b5a432c604088b6cc5df3630fda08895d829

Patch Set 1 #

Patch Set 2 : git pull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M include/gpu/GrContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrPathRendererChain.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 7 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1412883005 Patch 20001

Dependent Patchsets:

Issue 1424853002 Patch 1
Issue 1424853002 Patch 20001

Messages

Total messages: 11 (5 generated)
robertphillips
5 years, 1 month ago (2015-10-27 12:43:58 UTC) #3
bsalomon
On 2015/10/27 12:43:58, robertphillips wrote: Lookin' fab. lgtm
5 years, 1 month ago (2015-10-27 13:23:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422023003/20001
5 years, 1 month ago (2015-10-27 14:22:30 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 14:35:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422023003/20001
5 years, 1 month ago (2015-10-27 14:52:56 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 14:53:39 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cf10b5a432c604088b6cc5df3630fda08895d829

Powered by Google App Engine
This is Rietveld 408576698