Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142193004: Create & use microtask work queue (Closed)

Created:
6 years, 10 months ago by rafaelw
Modified:
6 years, 10 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Create & use microtask work queue This patch creates a simple FIFO queue for use by microtask work types and refactors MutationObservers to work by scheduling microtasks. Note that soon this queue will live in V8, but this patch will allow Custom Elements to be refactored in terms of microtasks thus de-coupling the V8 work from further blink work in this direction. R=adamk BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166252

Patch Set 1 #

Patch Set 2 : ws #

Total comments: 8

Patch Set 3 : cr changes #

Total comments: 4

Patch Set 4 : moar #

Patch Set 5 : fix for inspector #

Patch Set 6 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -37 lines) Patch
M Source/bindings/v8/V8PerIsolateData.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/Microtask.h View 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Microtask.cpp View 1 2 3 1 chunk +29 lines, -9 lines 0 comments Download
M Source/core/dom/MutationObserver.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 2 3 4 3 chunks +31 lines, -27 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
rafaelw
6 years, 10 months ago (2014-01-29 22:40:10 UTC) #1
adamk
Mostly looks fine, but a few nits and questions. https://codereview.chromium.org/142193004/diff/20001/Source/bindings/v8/V8PerIsolateData.h File Source/bindings/v8/V8PerIsolateData.h (right): https://codereview.chromium.org/142193004/diff/20001/Source/bindings/v8/V8PerIsolateData.h#newcode107 Source/bindings/v8/V8PerIsolateData.h:107: ...
6 years, 10 months ago (2014-01-29 22:58:24 UTC) #2
rafaelw
https://codereview.chromium.org/142193004/diff/20001/Source/bindings/v8/V8PerIsolateData.h File Source/bindings/v8/V8PerIsolateData.h (right): https://codereview.chromium.org/142193004/diff/20001/Source/bindings/v8/V8PerIsolateData.h#newcode107 Source/bindings/v8/V8PerIsolateData.h:107: bool performingCheckpoint() const { return m_performingCheckpoint; } On 2014/01/29 ...
6 years, 10 months ago (2014-01-29 23:18:51 UTC) #3
rafaelw
6 years, 10 months ago (2014-01-29 23:18:57 UTC) #4
adamk
https://codereview.chromium.org/142193004/diff/40001/Source/bindings/v8/V8PerIsolateData.h File Source/bindings/v8/V8PerIsolateData.h (right): https://codereview.chromium.org/142193004/diff/40001/Source/bindings/v8/V8PerIsolateData.h#newcode107 Source/bindings/v8/V8PerIsolateData.h:107: bool performingCheckpoint() const { return m_performingCheckpoint; } Looks like ...
6 years, 10 months ago (2014-01-29 23:27:15 UTC) #5
rafaelw
https://codereview.chromium.org/142193004/diff/40001/Source/bindings/v8/V8PerIsolateData.h File Source/bindings/v8/V8PerIsolateData.h (right): https://codereview.chromium.org/142193004/diff/40001/Source/bindings/v8/V8PerIsolateData.h#newcode107 Source/bindings/v8/V8PerIsolateData.h:107: bool performingCheckpoint() const { return m_performingCheckpoint; } On 2014/01/29 ...
6 years, 10 months ago (2014-01-29 23:43:28 UTC) #6
adamk
lgtm
6 years, 10 months ago (2014-01-29 23:44:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/142193004/100001
6 years, 10 months ago (2014-01-31 01:21:43 UTC) #8
rafaelw
Adam, PTAL my solution to resuming suspended observers. It seemed like too much to make ...
6 years, 10 months ago (2014-01-31 01:22:20 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24801
6 years, 10 months ago (2014-01-31 04:33:42 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 04:33:46 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 04:33:50 UTC) #12
rafaelw
The CQ bit was checked by rafaelw@chromium.org
6 years, 10 months ago (2014-01-31 22:26:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/142193004/100001
6 years, 10 months ago (2014-01-31 22:26:58 UTC) #14
commit-bot: I haz the power
Change committed as 166252
6 years, 10 months ago (2014-02-01 00:14:54 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 00:14:55 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 00:15:02 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-01 00:15:53 UTC) #18
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698