Create & use microtask work queue

Source/core/dom/Microtask.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/dom/Microtask.h"
 
+#include "bindings/v8/V8PerIsolateData.h"
 #include "core/dom/MutationObserver.h"
 #include "core/dom/custom/CustomElementScheduler.h"
 #include "wtf/Vector.h"
 
 namespace WebCore {
 
+typedef Vector<MicrotaskCallback> MicrotaskQueue;
+
+static MicrotaskQueue& microtaskQueue()
+{
+    DEFINE_STATIC_LOCAL(MicrotaskQueue, microtaskQueue, ());
+    return microtaskQueue;
+}
+
 void Microtask::performCheckpoint()

[adamk, 2014/01/29 22:58:24]

Will this one day take a v8::Isolate* argument? If not, we might want to just
make performingCheckpoint a ThreadLocal that's only visible in this file/class

[rafaelw, 2014/01/29 23:18:52]

We'll soon need a threadlocal get in order to retrieve the Isolate/Context so
that we can use the V8 API.

On 2014/01/29 22:58:24, adamk wrote:

 {
-    static bool performingCheckpoint = false;
-    if (performingCheckpoint)
+    V8PerIsolateData* isolateData = V8PerIsolateData::current();
+    ASSERT(isolateData);
+    if (isolateData->performingCheckpoint())
         return;
-    performingCheckpoint = true;
+    isolateData->setPerformingCheckpoint(true);
 
-    bool anyWorkDone;
-    do {
-        MutationObserver::deliverAllMutations();
-        anyWorkDone = CustomElementScheduler::dispatchMicrotaskProcessingSteps();
-    } while (anyWorkDone);
+    // FIXME: Custom element's callbacks need to be refactored to enqueueMicrotask()
+    while (CustomElementScheduler::dispatchMicrotaskProcessingSteps() || !microtaskQueue().isEmpty()) {
+        if (microtaskQueue().isEmpty())
+            continue;
+        Vector<MicrotaskCallback> microtasks;
+        microtasks.swap(microtaskQueue());
+        for (size_t i = 0; i < microtasks.size(); ++i) {
+            microtasks[i]();
+        }
+    }
 
-    performingCheckpoint = false;
+    isolateData->setPerformingCheckpoint(false);
+}
+
+void Microtask::enqueueMicrotask(MicrotaskCallback callback)
+{
+    microtaskQueue().append(callback);
 }
 
 } // namespace WebCore