Settings Rewrite: Fork SyncSetupHandler for MD-Settings

content/browser/webui/web_ui_impl.cc

Index: content/browser/webui/web_ui_impl.cc
diff --git a/content/browser/webui/web_ui_impl.cc b/content/browser/webui/web_ui_impl.cc
index 8a24604a40316487b15139bf166280312bfc81d8..5022d8d394c06b4df3a0c2aa599b48d0203e2f6a 100644
--- a/content/browser/webui/web_ui_impl.cc
+++ b/content/browser/webui/web_ui_impl.cc
@@ -223,7 +223,7 @@ void WebUIImpl::ProcessWebUIMessage(const GURL& source_url,
 // WebUIImpl, protected: -------------------------------------------------------
 
 void WebUIImpl::AddMessageHandler(WebUIMessageHandler* handler) {

[Dan Beam, 2015/10/29 01:47:20]

this would be cooler, IMO:

template<class T>
T* WebUIImpl::CreateMessageHandler() {
  T* handler = new T(this);
  handlers_.push_back(handler);
  handler->RegisterMessages();
  return handler;
}

web_ui->CreateMessageHandler<SomeSpecificHandler>();

[tommycli, 2015/10/29 17:34:14]

Agreed. Unfortunately the vast majority of the 50-odd handlers currently have
only the T() constructor and rely on the T.set_web_ui method to set the web ui.

I didn't want to add the T(WebUI*) constructor on all of them right now.

-  DCHECK(!handler->web_ui());
+  DCHECK(!handler->web_ui() || handler->web_ui() == this);
   handler->set_web_ui(this);
   handler->RegisterMessages();
   handlers_.push_back(handler);