Settings Rewrite: Fork SyncSetupHandler for MD-Settings

content/browser/webui/web_ui_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/webui/web_ui_impl.h"
 
 #include "base/debug/dump_without_crashing.h"
 #include "base/json/json_writer.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 204 matching lines @@
   if (callback != message_callbacks_.end()) {
     // Forward this message and content on.
     callback->second.Run(&args);
   } else {
     NOTREACHED() << "Unhandled chrome.send(\"" << message << "\");";
   }
 }
 
 // WebUIImpl, protected: -------------------------------------------------------
 
 void WebUIImpl::AddMessageHandler(WebUIMessageHandler* handler) {

[Dan Beam, 2015/10/29 01:47:20]

this would be cooler, IMO:

template<class T>
T* WebUIImpl::CreateMessageHandler() {
  T* handler = new T(this);
  handlers_.push_back(handler);
  handler->RegisterMessages();
  return handler;
}

web_ui->CreateMessageHandler<SomeSpecificHandler>();

[tommycli, 2015/10/29 17:34:14]

Agreed. Unfortunately the vast majority of the 50-odd handlers currently have
only the T() constructor and rely on the T.set_web_ui method to set the web ui.

I didn't want to add the T(WebUI*) constructor on all of them right now.

-  DCHECK(!handler->web_ui());
+  DCHECK(!handler->web_ui() || handler->web_ui() == this);
   handler->set_web_ui(this);
   handler->RegisterMessages();
   handlers_.push_back(handler);
 }
 
 void WebUIImpl::ExecuteJavascript(const base::string16& javascript) {
   RenderFrameHost* target_frame = TargetFrame();
   if (target_frame) {
     if (!(ChildProcessSecurityPolicyImpl::GetInstance()->HasWebUIBindings(
               target_frame->GetProcess()->GetID()) ||
@@ skipping 27 matching lines @@
 }
 
 void WebUIImpl::AddToSetIfFrameNameMatches(
     std::set<RenderFrameHost*>* frame_set,
     RenderFrameHost* host) {
   if (host->GetFrameName() == frame_name_)
     frame_set->insert(host);
 }
 
 }  // namespace content