Landing Recent QUIC changes until: Fri Oct 30 22:23:58 2015 +0000

Landing Recent QUIC changes until: Fri Oct 30 22:23:58 2015 +0000

Change QuicAckFrame's revived_packets to be a single QuicPacketNumber. QUIC now ignores all but the last packet revived by FEC.

Consumes 24 bytes less and is faster and simpler.

Merge internal change: 106729701
https://codereview.chromium.org/1431693002/

Fix a comment in quic_dispatcher.cc to mention the correct method.

Merge internal change: 106724344
https://codereview.chromium.org/1418213011/

Add a new method to QuicSpdySession

Add a public method OnHeadersHeadOfLineBlocking() which does
nothing. This method is used to replace EXPECT_CALL(Log()) in quic
headers stream test.

Merge internal change: 106716057
https://codereview.chromium.org/1410243007/

Simplify QUIC stateless rejects by latching the value of FLAGS_enable_quic_stateless_reject_support directly in the QuicCryptoServerStream constructor instead of requiring that it be passed in via a setter.

Merge internal change: 106714904
https://codereview.chromium.org/1411223011/

Add support of serving SCT on the server side in QUIC, gated by QUIC_VERSION_30.

Add support of serving SCT in QUIC. Flag-protected.

The protocol works like below:
1. The client sends CSCT tag associated with an empty value in client
hello to indicate that it supports cert transparency.
2. If so, the server responds with the signed certificate
timestamp (SCT) using the same tag.

Merge internal change: 106709176
https://codereview.chromium.org/1416583005/

Put a space between available window value and ">=" in log output.

Merge internal change: 106687764
https://codereview.chromium.org/1424313006/

Remove FLAGS_quic_session_map_threshold_for_stateless_rejects, and instead always use stateless rejects when the peer supports it and when FLAGS_gfe2_reloadable_flag_enable_quic_stateless_reject_support is true.

Merge internal change: 106656452
https://codereview.chromium.org/1417033008/

Create a new data structure StreamSequencerBuffer for QuicStreamSequencer. Currently QuicStreamSequencer is using std::list to store frames, which could buffer a series of tiny stream frames if the frames arrive so. And they are read out independently as very small strings never coalesced.

StreamSequencerBuffer coalesce these small strings and read them out as
a whole. It is a circular stream buffer with random write and
in-sequence read. It consists of an array of pointers pointing to memory
block de/allocated using new/delete and a list of GapRange objects to
indicate the missing data between the data already been written into the
buffer. And it keeps tracking the total bytes having been read out.

Merge internal change: 106593539
https://codereview.chromium.org/1409053006/

Remove unused method OnPacketSent from QuicPacketDroppingTestWriter::Delegate.

Merge internal change: 106492030
https://codereview.chromium.org/1422563005/

Remove unused member variables.  No functional change.

Remove unused QuicClock from TcpCubicSender and TcpCubicBytesSender.

Merge internal change: 106458891
https://codereview.chromium.org/1406023017/

Remove unused input argument. No functional change expected.

Merge internal change: 106451721
https://codereview.chromium.org/1410013010/

Change QuicWallTime to have microsecond granularity.

Merge internal change: 106446616
https://codereview.chromium.org/1421873007/

On client address changes, only migrate QUIC connections when client address changes are considered to be caused by NATs.

Add an enum PeerAddressChangeType. On each peer address change, the
change type is determined before the connection migration.

Merge internal change: 106444524
https://codereview.chromium.org/1420623004/

Make QUIC stateless rejects work in the face of packet loss by storing the SREJ packet(s) in the QuicTimeWaitListManager so they can be retransmitted.

Store QUIC SREJ packet(s) in the QuicTimeWaitListManager.

Merge internal change: 106433678
https://codereview.chromium.org/1424653008/

Remove QuicPacketCreator::fec_group_number_; replace it with QuicFecGroupInterface::FecGroupNumber().  No behavior change expected.

Merge internal change: 106432163
https://codereview.chromium.org/1409813006/

Remove unused QuicErrorCode QUIC_PACKET_FOR_NONEXISTENT_STREAM. No behavior change.

Merge internal change: 106425553
https://codereview.chromium.org/1408963003/

Merge GetIncomingDynamicStream and GetDynamicStream into a single GetOrCreateDynamicStream method in QuicSession. No behavior change.

Merge internal change: 106421704
https://codereview.chromium.org/1422533006/

Rename MockHelper to the more descriptive (and more consistent with other Mock classes) MockConnectionHelper.

Merge internal change: 106419223
https://codereview.chromium.org/1433433003/

Remove the QuicPacketGenerator from the PacketTooLarge EndToEndTest and no longer allow too large packets to be created by the QuicPacketCreator.

Merge internal change: 106414015
https://codereview.chromium.org/1411953005/

fix a comment in quic_session.h

Merge internal change: 106400931
https://codereview.chromium.org/1408183008/

Cleanup: Call OnWriteError instead of directly closing the connection when failing to send a QUIC version negotiation packet. No behavior change.

Merge internal change: 106397442
https://codereview.chromium.org/1424043003/

Removing quic_allow_oversized_packets_for_test by generating and writing packets without a QuicConnection.  Test-only change.

Merge internal change: 106394664
https://codereview.chromium.org/1415743010/

Change QuicFramer::EncryptPayload to return the length of the encrypted payload rather than a new EncryptedPacket.

Merge internal change: 106389203

Fix QUIC end to end test

Merge internal change: 106366330
https://codereview.chromium.org/1421703005/

Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and TcpCubicBytesSender and replace with the identical kDefaultTCPMSS.  Also fixes an error where the bandwidth resumption check was incorrectly using kMaxPacketSize.  Changes bandwidth resumption CWNDs by less than 1%.

Merge internal change: 106356338
https://codereview.chromium.org/1413193009/

Correct (enlarge) the situations when QuicPacketGenerator::MaybeSendFecPacketAndCloseGroup calls packet_creator_.StopFecProtectingPackets.

Merge internal change: 106333315
https://codereview.chromium.org/1417533011/

Factor QuicCryptoClientStream APIs into QuicCryptoClientStreamBase.

Merge internal change: 106327944
https://codereview.chromium.org/1425363002/

Add new version QUIC_VERSION_29 in which streams honor RST_STREAM + NO_ERROR.

Override QuicDataStream OnStreamReset method to honor
QUIC_STREAM_NO_ERROR on QUIC_VERSION_29 and later versions: close write
side only and leave read side open to read response data from server.

Merge internal change: 106313860
https://codereview.chromium.org/1413143004/

Committed: https://crrev.com/99b644cbd649fe031f0fdf882177c89484a65e73
Cr-Commit-Position: refs/heads/master@{#357761}

[Ryan Hamilton, 2015-11-02 23:52:18]

Description was changed from

==========
Landing Recent QUIC changes until: Fri Oct 30 22:23:58 2015 +0000

Change QuicAckFrame's revived_packets to be a single QuicPacketNumber. QUIC now
ignores all but the last packet revived by FEC.

Consumes 24 bytes less and is faster and simpler.

Merge internal change: 106729701

Fix a comment in quic_dispatcher.cc to mention the correct method.

Merge internal change: 106724344

Add a new method to QuicSpdySession

Add a public method OnHeadersHeadOfLineBlocking() which does
nothing. This method is used to replace EXPECT_CALL(Log()) in quic
headers stream test.

Merge internal change: 106716057

Simplify QUIC stateless rejects by latching the value of
FLAGS_enable_quic_stateless_reject_support directly in the
QuicCryptoServerStream constructor instead of requiring that it be passed in via
a setter.

Merge internal change: 106714904

Add support of serving SCT on the server side in QUIC, gated by QUIC_VERSION_30.

Add support of serving SCT in QUIC. Flag-protected.

The protocol works like below:
1. The client sends CSCT tag associated with an empty value in client
hello to indicate that it supports cert transparency.
2. If so, the server responds with the signed certificate
timestamp (SCT) using the same tag.

Merge internal change: 106709176

Put a space between available window value and ">=" in log output.

Merge internal change: 106687764

Remove FLAGS_quic_session_map_threshold_for_stateless_rejects, and instead
always use stateless rejects when the peer supports it and when
FLAGS_gfe2_reloadable_flag_enable_quic_stateless_reject_support is true.

Merge internal change: 106656452

fix


Create a new data structure StreamSequencerBuffer for QuicStreamSequencer.
Currently QuicStreamSequencer is using std::list to store frames, which could
buffer a series of tiny stream frames if the frames arrive so. And they are read
out independently as very small strings never coalesced.

StreamSequencerBuffer coalesce these small strings and read them out as
a whole. It is a circular stream buffer with random write and
in-sequence read. It consists of an array of pointers pointing to memory
block de/allocated using new/delete and a list of GapRange objects to
indicate the missing data between the data already been written into the
buffer. And it keeps tracking the total bytes having been read out.

Merge internal change: 106593539

fix


Remove unused method OnPacketSent from QuicPacketDroppingTestWriter::Delegate.

Merge internal change: 106492030

Remove unused member variables.  No functional change.

Remove unused QuicClock from TcpCubicSender and TcpCubicBytesSender.

Merge internal change: 106458891

Remove unused input argument. No functional change expected.

Merge internal change: 106451721

Change QuicWallTime to have microsecond granularity.

Merge internal change: 106446616

On client address changes, only migrate QUIC connections when client address
changes are considered to be caused by NATs.

Add an enum PeerAddressChangeType. On each peer address change, the
change type is determined before the connection migration.

Merge internal change: 106444524

fix


Make QUIC stateless rejects work in the face of packet loss by storing the SREJ
packet(s) in the QuicTimeWaitListManager so they can be retransmitted.

Store QUIC SREJ packet(s) in the QuicTimeWaitListManager.

Merge internal change: 106433678

Remove QuicPacketCreator::fec_group_number_; replace it with
QuicFecGroupInterface::FecGroupNumber().  No behavior change expected.

Merge internal change: 106432163

Remove unused QuicErrorCode QUIC_PACKET_FOR_NONEXISTENT_STREAM. No behavior
change.

Merge internal change: 106425553

Merge GetIncomingDynamicStream and GetDynamicStream into a single
GetOrCreateDynamicStream method in QuicSession. No behavior change.

Merge internal change: 106421704

Rename MockHelper to the more descriptive (and more consistent with other Mock
classes) MockConnectionHelper.

Merge internal change: 106419223

Rename MockHelper to the more descriptive (and more consistent with other Mock
classes) MockConnectionHelper.

Merge internal change: 106419223

Remove the QuicPacketGenerator from the PacketTooLarge EndToEndTest and no
longer allow too large packets to be created by the QuicPacketCreator.

Merge internal change: 106414015

fix a comment in quic_session.h

Merge internal change: 106400931

Cleanup: Call OnWriteError instead of directly closing the connection when
failing to send a QUIC version negotiation packet. No behavior change.

Merge internal change: 106397442

Removing quic_allow_oversized_packets_for_test by generating and writing packets
without a QuicConnection.  Test-only change.

Merge internal change: 106394664

fix


Change QuicFramer::EncryptPayload to return the length of the encrypted payload
rather than a new EncryptedPacket.

Merge internal change: 106389203

Fix QUIC end to end test

Merge internal change: 106366330

Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and
TcpCubicBytesSender and replace with the identical kDefaultTCPMSS.  Also fixes
an error where the bandwidth resumption check was incorrectly using
kMaxPacketSize.  Changes bandwidth resumption CWNDs by less than 1%.

Merge internal change: 106356338

Correct (enlarge) the situations when
QuicPacketGenerator::MaybeSendFecPacketAndCloseGroup calls
packet_creator_.StopFecProtectingPackets.

Merge internal change: 106333315

Factor QuicCryptoClientStream APIs into QuicCryptoClientStreamBase.

Merge internal change: 106327944

Add new version QUIC_VERSION_29 in which streams honor RST_STREAM + NO_ERROR.

Override QuicDataStream OnStreamReset method to honor
QUIC_STREAM_NO_ERROR on QUIC_VERSION_29 and later versions: close write
side only and leave read side open to read response data from server.

Merge internal change: 106313860

BUG=
==========

to

==========
Landing Recent QUIC changes until: Fri Oct 30 22:23:58 2015 +0000

Change QuicAckFrame's revived_packets to be a single QuicPacketNumber. QUIC now
ignores all but the last packet revived by FEC.

Consumes 24 bytes less and is faster and simpler.

Merge internal change: 106729701

Fix a comment in quic_dispatcher.cc to mention the correct method.

Merge internal change: 106724344

Add a new method to QuicSpdySession

Add a public method OnHeadersHeadOfLineBlocking() which does
nothing. This method is used to replace EXPECT_CALL(Log()) in quic
headers stream test.

Merge internal change: 106716057

Simplify QUIC stateless rejects by latching the value of
FLAGS_enable_quic_stateless_reject_support directly in the
QuicCryptoServerStream constructor instead of requiring that it be passed in via
a setter.

Merge internal change: 106714904

Add support of serving SCT on the server side in QUIC, gated by QUIC_VERSION_30.

Add support of serving SCT in QUIC. Flag-protected.

The protocol works like below:
1. The client sends CSCT tag associated with an empty value in client
hello to indicate that it supports cert transparency.
2. If so, the server responds with the signed certificate
timestamp (SCT) using the same tag.

Merge internal change: 106709176

Put a space between available window value and ">=" in log output.

Merge internal change: 106687764

Remove FLAGS_quic_session_map_threshold_for_stateless_rejects, and instead
always use stateless rejects when the peer supports it and when
FLAGS_gfe2_reloadable_flag_enable_quic_stateless_reject_support is true.

Merge internal change: 106656452

fix


Create a new data structure StreamSequencerBuffer for QuicStreamSequencer.
Currently QuicStreamSequencer is using std::list to store frames, which could
buffer a series of tiny stream frames if the frames arrive so. And they are read
out independently as very small strings never coalesced.

StreamSequencerBuffer coalesce these small strings and read them out as
a whole. It is a circular stream buffer with random write and
in-sequence read. It consists of an array of pointers pointing to memory
block de/allocated using new/delete and a list of GapRange objects to
indicate the missing data between the data already been written into the
buffer. And it keeps tracking the total bytes having been read out.

Merge internal change: 106593539

fix


Remove unused method OnPacketSent from QuicPacketDroppingTestWriter::Delegate.

Merge internal change: 106492030

Remove unused member variables.  No functional change.

Remove unused QuicClock from TcpCubicSender and TcpCubicBytesSender.

Merge internal change: 106458891

Remove unused input argument. No functional change expected.

Merge internal change: 106451721

Change QuicWallTime to have microsecond granularity.

Merge internal change: 106446616

On client address changes, only migrate QUIC connections when client address
changes are considered to be caused by NATs.

Add an enum PeerAddressChangeType. On each peer address change, the
change type is determined before the connection migration.

Merge internal change: 106444524

fix


Make QUIC stateless rejects work in the face of packet loss by storing the SREJ
packet(s) in the QuicTimeWaitListManager so they can be retransmitted.

Store QUIC SREJ packet(s) in the QuicTimeWaitListManager.

Merge internal change: 106433678

Remove QuicPacketCreator::fec_group_number_; replace it with
QuicFecGroupInterface::FecGroupNumber().  No behavior change expected.

Merge internal change: 106432163

Remove unused QuicErrorCode QUIC_PACKET_FOR_NONEXISTENT_STREAM. No behavior
change.

Merge internal change: 106425553

Merge GetIncomingDynamicStream and GetDynamicStream into a single
GetOrCreateDynamicStream method in QuicSession. No behavior change.

Merge internal change: 106421704

Rename MockHelper to the more descriptive (and more consistent with other Mock
classes) MockConnectionHelper.

Merge internal change: 106419223

Rename MockHelper to the more descriptive (and more consistent with other Mock
classes) MockConnectionHelper.

Merge internal change: 106419223

Remove the QuicPacketGenerator from the PacketTooLarge EndToEndTest and no
longer allow too large packets to be created by the QuicPacketCreator.

Merge internal change: 106414015

fix a comment in quic_session.h

Merge internal change: 106400931

Cleanup: Call OnWriteError instead of directly closing the connection when
failing to send a QUIC version negotiation packet. No behavior change.

Merge internal change: 106397442

Removing quic_allow_oversized_packets_for_test by generating and writing packets
without a QuicConnection.  Test-only change.

Merge internal change: 106394664

fix


Change QuicFramer::EncryptPayload to return the length of the encrypted payload
rather than a new EncryptedPacket.

Merge internal change: 106389203

Fix QUIC end to end test

Merge internal change: 106366330

Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and
TcpCubicBytesSender and replace with the identical kDefaultTCPMSS.  Also fixes
an error where the bandwidth resumption check was incorrectly using
kMaxPacketSize.  Changes bandwidth resumption CWNDs by less than 1%.

Merge internal change: 106356338

Correct (enlarge) the situations when
QuicPacketGenerator::MaybeSendFecPacketAndCloseGroup calls
packet_creator_.StopFecProtectingPackets.

Merge internal change: 106333315

Factor QuicCryptoClientStream APIs into QuicCryptoClientStreamBase.

Merge internal change: 106327944

Add new version QUIC_VERSION_29 in which streams honor RST_STREAM + NO_ERROR.

Override QuicDataStream OnStreamReset method to honor
QUIC_STREAM_NO_ERROR on QUIC_VERSION_29 and later versions: close write
side only and leave read side open to read response data from server.

Merge internal change: 106313860

BUG=
==========

[Ryan Hamilton, 2015-11-02 23:52:18]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[Ryan Hamilton, 2015-11-02 23:57:41]

Description was changed from

==========
Landing Recent QUIC changes until: Fri Oct 30 22:23:58 2015 +0000

Change QuicAckFrame's revived_packets to be a single QuicPacketNumber. QUIC now
ignores all but the last packet revived by FEC.

Consumes 24 bytes less and is faster and simpler.

Merge internal change: 106729701

Fix a comment in quic_dispatcher.cc to mention the correct method.

Merge internal change: 106724344

Add a new method to QuicSpdySession

Add a public method OnHeadersHeadOfLineBlocking() which does
nothing. This method is used to replace EXPECT_CALL(Log()) in quic
headers stream test.

Merge internal change: 106716057

Simplify QUIC stateless rejects by latching the value of
FLAGS_enable_quic_stateless_reject_support directly in the
QuicCryptoServerStream constructor instead of requiring that it be passed in via
a setter.

Merge internal change: 106714904

Add support of serving SCT on the server side in QUIC, gated by QUIC_VERSION_30.

Add support of serving SCT in QUIC. Flag-protected.

The protocol works like below:
1. The client sends CSCT tag associated with an empty value in client
hello to indicate that it supports cert transparency.
2. If so, the server responds with the signed certificate
timestamp (SCT) using the same tag.

Merge internal change: 106709176

Put a space between available window value and ">=" in log output.

Merge internal change: 106687764

Remove FLAGS_quic_session_map_threshold_for_stateless_rejects, and instead
always use stateless rejects when the peer supports it and when
FLAGS_gfe2_reloadable_flag_enable_quic_stateless_reject_support is true.

Merge internal change: 106656452

fix


Create a new data structure StreamSequencerBuffer for QuicStreamSequencer.
Currently QuicStreamSequencer is using std::list to store frames, which could
buffer a series of tiny stream frames if the frames arrive so. And they are read
out independently as very small strings never coalesced.

StreamSequencerBuffer coalesce these small strings and read them out as
a whole. It is a circular stream buffer with random write and
in-sequence read. It consists of an array of pointers pointing to memory
block de/allocated using new/delete and a list of GapRange objects to
indicate the missing data between the data already been written into the
buffer. And it keeps tracking the total bytes having been read out.

Merge internal change: 106593539

fix


Remove unused method OnPacketSent from QuicPacketDroppingTestWriter::Delegate.

Merge internal change: 106492030

Remove unused member variables.  No functional change.

Remove unused QuicClock from TcpCubicSender and TcpCubicBytesSender.

Merge internal change: 106458891

Remove unused input argument. No functional change expected.

Merge internal change: 106451721

Change QuicWallTime to have microsecond granularity.

Merge internal change: 106446616

On client address changes, only migrate QUIC connections when client address
changes are considered to be caused by NATs.

Add an enum PeerAddressChangeType. On each peer address change, the
change type is determined before the connection migration.

Merge internal change: 106444524

fix


Make QUIC stateless rejects work in the face of packet loss by storing the SREJ
packet(s) in the QuicTimeWaitListManager so they can be retransmitted.

Store QUIC SREJ packet(s) in the QuicTimeWaitListManager.

Merge internal change: 106433678

Remove QuicPacketCreator::fec_group_number_; replace it with
QuicFecGroupInterface::FecGroupNumber().  No behavior change expected.

Merge internal change: 106432163

Remove unused QuicErrorCode QUIC_PACKET_FOR_NONEXISTENT_STREAM. No behavior
change.

Merge internal change: 106425553

Merge GetIncomingDynamicStream and GetDynamicStream into a single
GetOrCreateDynamicStream method in QuicSession. No behavior change.

Merge internal change: 106421704

Rename MockHelper to the more descriptive (and more consistent with other Mock
classes) MockConnectionHelper.

Merge internal change: 106419223

Rename MockHelper to the more descriptive (and more consistent with other Mock
classes) MockConnectionHelper.

Merge internal change: 106419223

Remove the QuicPacketGenerator from the PacketTooLarge EndToEndTest and no
longer allow too large packets to be created by the QuicPacketCreator.

Merge internal change: 106414015

fix a comment in quic_session.h

Merge internal change: 106400931

Cleanup: Call OnWriteError instead of directly closing the connection when
failing to send a QUIC version negotiation packet. No behavior change.

Merge internal change: 106397442

Removing quic_allow_oversized_packets_for_test by generating and writing packets
without a QuicConnection.  Test-only change.

Merge internal change: 106394664

fix


Change QuicFramer::EncryptPayload to return the length of the encrypted payload
rather than a new EncryptedPacket.

Merge internal change: 106389203

Fix QUIC end to end test

Merge internal change: 106366330

Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and
TcpCubicBytesSender and replace with the identical kDefaultTCPMSS.  Also fixes
an error where the bandwidth resumption check was incorrectly using
kMaxPacketSize.  Changes bandwidth resumption CWNDs by less than 1%.

Merge internal change: 106356338

Correct (enlarge) the situations when
QuicPacketGenerator::MaybeSendFecPacketAndCloseGroup calls
packet_creator_.StopFecProtectingPackets.

Merge internal change: 106333315

Factor QuicCryptoClientStream APIs into QuicCryptoClientStreamBase.

Merge internal change: 106327944

Add new version QUIC_VERSION_29 in which streams honor RST_STREAM + NO_ERROR.

Override QuicDataStream OnStreamReset method to honor
QUIC_STREAM_NO_ERROR on QUIC_VERSION_29 and later versions: close write
side only and leave read side open to read response data from server.

Merge internal change: 106313860

BUG=
==========

to

==========
Landing Recent QUIC changes until: Fri Oct 30 22:23:58 2015 +0000

Change QuicAckFrame's revived_packets to be a single QuicPacketNumber. QUIC now
ignores all but the last packet revived by FEC.

Consumes 24 bytes less and is faster and simpler.

Merge internal change: 106729701
https://codereview.chromium.org/1431693002/

Fix a comment in quic_dispatcher.cc to mention the correct method.

Merge internal change: 106724344
https://codereview.chromium.org/1418213011/

Add a new method to QuicSpdySession

Add a public method OnHeadersHeadOfLineBlocking() which does
nothing. This method is used to replace EXPECT_CALL(Log()) in quic
headers stream test.

Merge internal change: 106716057
https://codereview.chromium.org/1410243007/

Simplify QUIC stateless rejects by latching the value of
FLAGS_enable_quic_stateless_reject_support directly in the
QuicCryptoServerStream constructor instead of requiring that it be passed in via
a setter.

Merge internal change: 106714904
https://codereview.chromium.org/1411223011/

Add support of serving SCT on the server side in QUIC, gated by QUIC_VERSION_30.

Add support of serving SCT in QUIC. Flag-protected.

The protocol works like below:
1. The client sends CSCT tag associated with an empty value in client
hello to indicate that it supports cert transparency.
2. If so, the server responds with the signed certificate
timestamp (SCT) using the same tag.

Merge internal change: 106709176
https://codereview.chromium.org/1416583005/

Put a space between available window value and ">=" in log output.

Merge internal change: 106687764
https://codereview.chromium.org/1424313006/

Remove FLAGS_quic_session_map_threshold_for_stateless_rejects, and instead
always use stateless rejects when the peer supports it and when
FLAGS_gfe2_reloadable_flag_enable_quic_stateless_reject_support is true.

Merge internal change: 106656452
https://codereview.chromium.org/1417033008/

Create a new data structure StreamSequencerBuffer for QuicStreamSequencer.
Currently QuicStreamSequencer is using std::list to store frames, which could
buffer a series of tiny stream frames if the frames arrive so. And they are read
out independently as very small strings never coalesced.

StreamSequencerBuffer coalesce these small strings and read them out as
a whole. It is a circular stream buffer with random write and
in-sequence read. It consists of an array of pointers pointing to memory
block de/allocated using new/delete and a list of GapRange objects to
indicate the missing data between the data already been written into the
buffer. And it keeps tracking the total bytes having been read out.

Merge internal change: 106593539
https://codereview.chromium.org/1409053006/

Remove unused method OnPacketSent from QuicPacketDroppingTestWriter::Delegate.

Merge internal change: 106492030
https://codereview.chromium.org/1422563005/

Remove unused member variables.  No functional change.

Remove unused QuicClock from TcpCubicSender and TcpCubicBytesSender.

Merge internal change: 106458891
https://codereview.chromium.org/1406023017/

Remove unused input argument. No functional change expected.

Merge internal change: 106451721
https://codereview.chromium.org/1410013010/

Change QuicWallTime to have microsecond granularity.

Merge internal change: 106446616
https://codereview.chromium.org/1421873007/

On client address changes, only migrate QUIC connections when client address
changes are considered to be caused by NATs.

Add an enum PeerAddressChangeType. On each peer address change, the
change type is determined before the connection migration.

Merge internal change: 106444524
https://codereview.chromium.org/1420623004/

Make QUIC stateless rejects work in the face of packet loss by storing the SREJ
packet(s) in the QuicTimeWaitListManager so they can be retransmitted.

Store QUIC SREJ packet(s) in the QuicTimeWaitListManager.

Merge internal change: 106433678
https://codereview.chromium.org/1424653008/

Remove QuicPacketCreator::fec_group_number_; replace it with
QuicFecGroupInterface::FecGroupNumber().  No behavior change expected.

Merge internal change: 106432163
https://codereview.chromium.org/1409813006/

Remove unused QuicErrorCode QUIC_PACKET_FOR_NONEXISTENT_STREAM. No behavior
change.

Merge internal change: 106425553
https://codereview.chromium.org/1408963003/

Merge GetIncomingDynamicStream and GetDynamicStream into a single
GetOrCreateDynamicStream method in QuicSession. No behavior change.

Merge internal change: 106421704
https://codereview.chromium.org/1422533006/

Rename MockHelper to the more descriptive (and more consistent with other Mock
classes) MockConnectionHelper.

Merge internal change: 106419223
https://codereview.chromium.org/1433433003/

Remove the QuicPacketGenerator from the PacketTooLarge EndToEndTest and no
longer allow too large packets to be created by the QuicPacketCreator.

Merge internal change: 106414015
https://codereview.chromium.org/1411953005/

fix a comment in quic_session.h

Merge internal change: 106400931
https://codereview.chromium.org/1408183008/

Cleanup: Call OnWriteError instead of directly closing the connection when
failing to send a QUIC version negotiation packet. No behavior change.

Merge internal change: 106397442
https://codereview.chromium.org/1424043003/

Removing quic_allow_oversized_packets_for_test by generating and writing packets
without a QuicConnection.  Test-only change.

Merge internal change: 106394664
https://codereview.chromium.org/1415743010/

Change QuicFramer::EncryptPayload to return the length of the encrypted payload
rather than a new EncryptedPacket.

Merge internal change: 106389203

Fix QUIC end to end test

Merge internal change: 106366330
https://codereview.chromium.org/1421703005/

Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and
TcpCubicBytesSender and replace with the identical kDefaultTCPMSS.  Also fixes
an error where the bandwidth resumption check was incorrectly using
kMaxPacketSize.  Changes bandwidth resumption CWNDs by less than 1%.

Merge internal change: 106356338
https://codereview.chromium.org/1413193009/

Correct (enlarge) the situations when
QuicPacketGenerator::MaybeSendFecPacketAndCloseGroup calls
packet_creator_.StopFecProtectingPackets.

Merge internal change: 106333315
https://codereview.chromium.org/1417533011/

Factor QuicCryptoClientStream APIs into QuicCryptoClientStreamBase.

Merge internal change: 106327944
https://codereview.chromium.org/1425363002/

Add new version QUIC_VERSION_29 in which streams honor RST_STREAM + NO_ERROR.

Override QuicDataStream OnStreamReset method to honor
QUIC_STREAM_NO_ERROR on QUIC_VERSION_29 and later versions: close write
side only and leave read side open to read response data from server.

Merge internal change: 106313860
https://codereview.chromium.org/1413143004/
==========

[ramant (doing other things), 2015-11-03 00:43:36]

lgtm

[Ryan Hamilton, 2015-11-03 14:54:43]

rch@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Ryan Hamilton, 2015-11-03 14:54:45]

xunjieli: components/cronet/ OWNERS please

[xunjieli, 2015-11-03 15:19:07]

On 2015/11/03 14:54:45, Ryan Hamilton wrote:
> xunjieli: components/cronet/ OWNERS please

lgtm assuming Cronet tests are passing.
You could verify locally by doing (We don't yet have a trybot):
components/cronet/tools/cr_cronet.py gyp
components/cronet/tools/cr_cronet.py build-test --test-filter=QuicTest*

[Ryan Hamilton, 2015-11-03 23:12:50]

On 2015/11/03 15:19:07, xunjieli wrote:
> On 2015/11/03 14:54:45, Ryan Hamilton wrote:
> > xunjieli: components/cronet/ OWNERS please
> 
> lgtm assuming Cronet tests are passing.
> You could verify locally by doing (We don't yet have a trybot):
> components/cronet/tools/cr_cronet.py gyp
> components/cronet/tools/cr_cronet.py build-test --test-filter=QuicTest*

components/cronet/tools/cr_cronet.py build-test --test-filter=QuicTest\*
Namespace(command='build-test', release=False)
['--test-filter=QuicTest*']
ninja -C out/Debug cronet_test_instrumentation_apk 
ninja: Entering directory `out/Debug'
ninja: error: unknown target 'cronet_test_instrumentation_apk'

:(

[xunjieli, 2015-11-03 23:22:02]

On 2015/11/03 23:12:50, Ryan Hamilton wrote:
> On 2015/11/03 15:19:07, xunjieli wrote:
> > On 2015/11/03 14:54:45, Ryan Hamilton wrote:
> > > xunjieli: components/cronet/ OWNERS please
> > 
> > lgtm assuming Cronet tests are passing.
> > You could verify locally by doing (We don't yet have a trybot):
> > components/cronet/tools/cr_cronet.py gyp
> > components/cronet/tools/cr_cronet.py build-test --test-filter=QuicTest*
> 
> components/cronet/tools/cr_cronet.py build-test --test-filter=QuicTest\*
> Namespace(command='build-test', release=False)
> ['--test-filter=QuicTest*']
> ninja -C out/Debug cronet_test_instrumentation_apk 
> ninja: Entering directory `out/Debug'
> ninja: error: unknown target 'cronet_test_instrumentation_apk'
> 
> :(

Looks like gyp target is missing. Have you done
"components/cronet/tools/cr_cronet.py gyp" before the "build-test"? Not very
clear in my previous comment that there are two steps.

[Ryan Hamilton, 2015-11-04 04:10:18]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-11-04 04:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org, xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/1421853006/#ps180001
(title: "fix comments")

[commit-bot: I haz the power, 2015-11-04 04:10:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421853006/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421853006/180001

[commit-bot: I haz the power, 2015-11-04 05:25:38]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-11-04 05:26:22]

Patchset 10 (id:??) landed as
https://crrev.com/99b644cbd649fe031f0fdf882177c89484a65e73
Cr-Commit-Position: refs/heads/master@{#357761}