Add immediate mode option for gpu configs in dm

Add immediate mode option for gpu configs in dm

Committed: https://skia.googlesource.com/skia/+/648c696438410fe0f0f5db9bb7935006fecf9cad

[bsalomon, 2015-10-23 15:37:12]

bsalomon@google.com changed reviewers:
+ joshualitt@google.com

[bsalomon, 2015-10-23 15:37:16]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-10-23 15:37:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421853002/20001

[commit-bot: I haz the power, 2015-10-23 15:37:22]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-10-23 21:37 UTC

[commit-bot: I haz the power, 2015-10-23 15:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 15:38:09]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bsalomon, 2015-10-23 15:41:14]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-10-23 15:41:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421853002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421853002/40001

[joshualitt, 2015-10-23 15:41:46]

https://codereview.chromium.org/1421853002/diff/20001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/1421853002/diff/20001/src/gpu/GrDrawTarget.cp...
src/gpu/GrDrawTarget.cpp:529: if (fOptions.fImmediateMode) {
In immediate mode we also want to set maxCandidates to 0 so we don't inorder
batch.

[bsalomon, 2015-10-23 15:42:34]

On 2015/10/23 15:41:46, joshualitt wrote:
> https://codereview.chromium.org/1421853002/diff/20001/src/gpu/GrDrawTarget.cpp
> File src/gpu/GrDrawTarget.cpp (right):
> 
>
https://codereview.chromium.org/1421853002/diff/20001/src/gpu/GrDrawTarget.cp...
> src/gpu/GrDrawTarget.cpp:529: if (fOptions.fImmediateMode) {
> In immediate mode we also want to set maxCandidates to 0 so we don't inorder
> batch.

The queue will always have size 0 when entering recordBatch, right?

[joshualitt, 2015-10-23 15:44:17]

On 2015/10/23 15:42:34, bsalomon wrote:
> On 2015/10/23 15:41:46, joshualitt wrote:
> >
https://codereview.chromium.org/1421853002/diff/20001/src/gpu/GrDrawTarget.cpp
> > File src/gpu/GrDrawTarget.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1421853002/diff/20001/src/gpu/GrDrawTarget.cp...
> > src/gpu/GrDrawTarget.cpp:529: if (fOptions.fImmediateMode) {
> > In immediate mode we also want to set maxCandidates to 0 so we don't inorder
> > batch.
> 
> The queue will always have size 0 when entering recordBatch, right?

yea you are right, nvm, lgtm.

[bsalomon, 2015-10-23 15:44:56]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2015-10-23 15:47:27]

On 2015/10/23 15:44:17, joshualitt wrote:
> On 2015/10/23 15:42:34, bsalomon wrote:
> > On 2015/10/23 15:41:46, joshualitt wrote:
> > >
> https://codereview.chromium.org/1421853002/diff/20001/src/gpu/GrDrawTarget.cpp
> > > File src/gpu/GrDrawTarget.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1421853002/diff/20001/src/gpu/GrDrawTarget.cp...
> > > src/gpu/GrDrawTarget.cpp:529: if (fOptions.fImmediateMode) {
> > > In immediate mode we also want to set maxCandidates to 0 so we don't
inorder
> > > batch.
> > 
> > The queue will always have size 0 when entering recordBatch, right?
> 
> yea you are right, nvm, lgtm.

added an assert to the effect.

[bsalomon, 2015-10-23 15:47:35]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-23 15:47:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1421853002/#ps60001
(title: "add assert")

[commit-bot: I haz the power, 2015-10-23 15:47:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421853002/60001

[bsalomon, 2015-10-23 16:02:35]

Patchset #5 (id:80001) has been deleted

[bsalomon, 2015-10-23 16:02:40]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-23 16:02:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1421853002/#ps60001
(title: "add assert")

[commit-bot: I haz the power, 2015-10-23 16:02:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421853002/60001

[commit-bot: I haz the power, 2015-10-23 16:07:02]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/648c696438410fe0f0f5db9bb7935006fecf9cad